Skip to content

Replace std::aligned_storage<T, ...> with alignas(T) unsigned char[] #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eoan-ermine wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −8
Open

Replace std::aligned_storage<T, ...> with alignas(T) unsigned char[] #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/boost/fiber/buffered_channel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,10 @@ class buffered_channel {

class iterator {
private:
typedef typename std::aligned_storage< sizeof( value_type), alignof( value_type) >::type storage_type;
typedef unsigned char storage_type[sizeof(value_type)];

buffered_channel * chan_{ nullptr };
storage_type storage_;
buffered_channel * chan_{ nullptr };
alignas(value_type) storage_type storage_;

void increment_( bool initial = false) {
BOOST_ASSERT( nullptr != chan_);
Expand Down
6 changes: 3 additions & 3 deletions include/boost/fiber/unbuffered_channel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,10 +392,10 @@ class unbuffered_channel {

class iterator {
private:
typedef typename std::aligned_storage< sizeof( value_type), alignof( value_type) >::type storage_type;
typedef unsigned char storage_type[sizeof(value_type)];

unbuffered_channel * chan_{ nullptr };
storage_type storage_;
unbuffered_channel * chan_{ nullptr };
alignas(value_type) storage_type storage_;

void increment_( bool initial = false) {
BOOST_ASSERT( nullptr != chan_);
Expand Down
4 changes: 2 additions & 2 deletions performance/thread/buffered_channel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ class buffered_channel {
typedef T value_type;

private:
typedef typename std::aligned_storage< sizeof( T), alignof( T) >::type storage_type;
typedef unsigned char storage_type[sizeof(T)];

struct alignas(cache_alignment) slot {
std::atomic< std::size_t > cycle{ 0 };
storage_type storage{};
alignas(T) storage_type storage{};

slot() = default;
};
Expand Down