Skip to content

Makefile: When running multiple tests using RUN, the command fails - #157

Open
HarshwardhanPatil07 wants to merge 1 commit into
bootc-dev:mainfrom
HarshwardhanPatil07:fix-run-regex-quoting
Open

Makefile: When running multiple tests using RUN, the command fails#157
HarshwardhanPatil07 wants to merge 1 commit into
bootc-dev:mainfrom
HarshwardhanPatil07:fix-run-regex-quoting

Conversation

@HarshwardhanPatil07

Copy link
Copy Markdown
Collaborator

More info in issue
Closes: #156

Regular expressions containing alternation are currently interpreted by the shell as pipelines because RUN is expanded without quoting. Quote the filter passed to go test in both the unit and e2e targets so normal Go test regular expressions work without escaping.

Closes: bootc-dev#156

Assisted-by: AI
Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
@HarshwardhanPatil07

Copy link
Copy Markdown
Collaborator Author

PTAL @Johan-Liebert1 @ptalgulk01 @alicefr

@ptalgulk01

Copy link
Copy Markdown
Collaborator

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makefile: When running multiple tests using RUN, the command fails

2 participants