blake3 extra: require blake3 >= 1.0.10 on all platforms - #235
Merged
Merged
Conversation
blake3 1.0.9 did not build on windows/msys2/mingw, so it was excluded there. 1.0.10 is out, so drop the win32-specific requirement line and require >= 1.0.10 everywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blake3 1.0.9 did not build on windows/msys2/mingw, so the
blake3extra excluded it there (b9a092e). blake3 1.0.10 is released (2026-09-29), so this drops the win32-specific requirement line and requiresblake3 >= 1.0.10on all platforms.Same change as borgbackup/borg#10489. borgstore's Windows CI job uses the native Windows Python (PyPI wheels), so the msys2/mingw source build is exercised by borg's
windows_testsjob on that PR, not here.1.0.10 also fixes a deadlock in
update()when one hasher withmax_threads > 1is shared by several threads (oconnor663/blake3-py#120).Locally (macOS, blake3 1.0.10):
pytest tests -k blake3passes.🤖 Generated with Claude Code