Repository navigation
Show status during slow Dagger engine startup - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Pretty progress now writes a status after one second when Dagger has not emitted application progress. The message tells the user that Dagger is still starting and may be downloading its engine image. Fast starts retain the existing concise output.
The progress event and startup status use the same mutex so the delayed message cannot appear after application progress begins. A subprocess regression test covers the delayed startup sequence.
Verification
mise exec ruby@4.0.6 -- bin/cimise exec ruby@3.2.11 -- bundle exec rake