Update Expo/Worklets integration and stabilizing the Android/iOS bridge - #33
Open
falleco wants to merge 2 commits into
Open
Update Expo/Worklets integration and stabilizing the Android/iOS bridge#33falleco wants to merge 2 commits into
falleco wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hey, guys! Not sure if you wanna bring this on, but I was always dealing with the same problems when starting a new project that uses this repo (awesome work, btw). So, this PR tries modernizes
react-native-godotfor the current Expo and React Native ecosystem, improves support for hoisted monorepos, and consolidates some native bridge stability fixes.It also fixes Android dependency resolution so consumers no longer need to manually configure a repository path through
expo-build-properties.Main changes
Expo and React Native compatibility
react-native-worklets-corewithreact-native-worklets.Expo config plugin
The package now includes an Expo config plugin that configures the required Android settings automatically:
minSdkVersionto 29, which is required by the AndroidSurfaceControlimplementation.armeabi-v7aarm64-v8aNow other devs no longer need to use this type of workaround:
Expo applications installed through Git or a workspace only need to register the package plugin:
The Android library also retains a Gradle-side fallback for non-Expo React Native applications.
Monorepo support
node_moduleslayout.Android stability
SurfaceControllifecycle handling.iOS stability
Compatibility notes
react-native-workletsand have it installed instead ofreact-native-worklets-core.References
The implementation was heavily based on other's works and adapted from the following community work:
Let me know if you wanna change something or just drop this, I wanted to use it as a drop-in replacement of your lib, so in practice to use it we just need to point to the fork repo, instead of using version
1.0.1.