fix(i18n): add missing translations for app detail page.#90
Draft
AjmalShajahan wants to merge 1 commit intobottlesdevs:mainfrom
Draft
fix(i18n): add missing translations for app detail page.#90AjmalShajahan wants to merge 1 commit intobottlesdevs:mainfrom
AjmalShajahan wants to merge 1 commit intobottlesdevs:mainfrom
Conversation
Fixes bottlesdevs#81 and bottlesdevs#88. Add missing strings and fallbacks.
AjmalShajahan
force-pushed
the
fix/app-detail-i18n-missing
branch
from
90e7313 to
6953b91
Compare
|
Great additions to the App Detail page! I'm currently working on PR #87 to add full Arabic support. Once your PR is merged, I'll update my PR to include the Arabic translations for these new strings (App grades, dependencies, configuration, etc.) to keep everything consistent. Keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81 and #88
Previews:
https://thankful-moss-0bff0fe1e-preview.westus2.7.azurestaticapps.net/appstore
https://thankful-moss-0bff0fe1e-preview.westus2.7.azurestaticapps.net/app#epicgamestore