Skip to content

feat: add cancel/refund flow with contributor-first escrow refund #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BWM0223 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add cancel/refund flow with contributor-first escrow refund #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions components/bounty/CancelRefundFlow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@

"use client";
import { useState } from "react";
import { Button } from "@/components/ui/button";
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from "@/components/ui/card";
import { AlertTriangle, XCircle } from "lucide-react";

interface CancelRefundFlowProps {
bountyId: string;
bountyTitle: string;
escrowBalance: number;
contributorCount: number;
onCancel: (bountyId: string) => Promise<void>;
onClose: () => void;
}

export function CancelRefundFlow({
bountyId, bountyTitle, escrowBalance, contributorCount, onCancel, onClose
}: CancelRefundFlowProps) {
const [step, setStep] = useState<"confirm" | "processing" | "done">("confirm");
const [error, setError] = useState<string | null>(null);

const handleCancel = async () => {
setStep("processing");
setError(null);
try {
await onCancel(bountyId);
setStep("done");
} catch (e: any) {
setError(e.message ?? "Cancellation failed");
setStep("confirm");
Comment on lines +29 to +31

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major

Replace any with unknown in error handling.

Line 29 uses any, which violates the type safety guidelines. Update the catch clause to accept unknown and use type narrowing before accessing properties.

Suggested fix 
    const handleCancel = async () =&gt; {
      setStep("processing");
      setError(null);
      try {
        await onCancel(bountyId);
        setStep("done");
-     } catch (e: any) {
-       setError(e.message ?? "Cancellation failed");
+     } catch (error: unknown) {
+       const message = error instanceof Error ? error.message : "Cancellation failed";
+       setError(message);
        setStep("confirm");
      }
    };
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
} catch (e: any) {
setError(e.message ?? "Cancellation failed");
setStep("confirm");
} catch (error: unknown) {
const message = error instanceof Error ? error.message : "Cancellation failed";
setError(message);
setStep("confirm");
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/bounty/CancelRefundFlow.tsx` around lines 29 - 31, The catch
handler in CancelRefundFlow should not use any; update the catch clause to
unknown and narrow the value before reading message. In the error-handling path
around setError and setStep, add a type guard or instanceof Error check so only
Error-like values access message, and keep the fallback "Cancellation failed"
for non-Error cases.

}
};

return (
<Card className="border-destructive">
<CardHeader>
<CardTitle className="flex items-center gap-2 text-destructive">
<XCircle className="h-5 w-5" />
{step === "done" ? "Bounty Cancelled" : "Cancel Bounty"}
</CardTitle>
<CardDescription>{bountyTitle}</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
{step === "confirm" && (
<>
<div className="bg-muted rounded-md p-3 space-y-2 text-sm">
<div className="flex items-start gap-2">
<AlertTriangle className="h-4 w-4 text-yellow-500 mt-0.5 shrink-0" />
<div>
<p className="font-medium">Refund order</p>
<ol className="list-decimal ml-4 mt-1 space-y-1 text-muted-foreground">
<li>Contributors refunded first ({contributorCount} contributor{contributorCount !== 1 ? "s" : ""})</li>
<li>Remaining escrow balance returned to you</li>
</ol>
</div>
</div>
<p className="text-muted-foreground">
Escrow balance: <strong>{escrowBalance} USDC</strong>
</p>
</div>
{error && <p className="text-destructive text-sm">{error}</p>}
<div className="flex gap-2">
<Button variant="destructive" onClick={handleCancel}>Confirm Cancellation</Button>
<Button variant="outline" onClick={onClose}>Keep Bounty</Button>
</div>
</>
)}
{step === "processing" && (
<p className="text-sm text-muted-foreground animate-pulse">Processing cancellation and refunds...</p>
)}
{step === "done" && (
<div className="space-y-3">
<p className="text-sm text-green-600">Bounty cancelled. Refunds are being processed.</p>
<Button variant="outline" onClick={onClose}>Close</Button>
</div>
)}
</CardContent>
</Card>
);
}

export default CancelRefundFlow;