Skip to content

perf: Precompute hash maps for ruleset dependency checks in Analyser #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Aug 17, 2026
Merged

perf: Precompute hash maps for ruleset dependency checks in Analyser #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions src/Analyser/Analyser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@

use function array_fill_keys;
use function array_filter;
use function array_intersect;
use function array_key_exists;
use function array_keys;
use function array_merge;
Expand Down Expand Up @@ -190,8 +189,22 @@ className: $violation->className,

// Evaluate declarative ruleset alongside class rules, but buffer its
// violations so report ordering remains class rules before ruleset.
$ruleset = $this->expandRuleset($architecture->getRuleset());
$classViolationSkips = $architecture->getClassViolationSkips();
$ruleset = $this->expandRuleset($architecture->getRuleset());

// Precompute hash maps once so the per-dependency hot loop below uses
// O(1) isset() lookups instead of in_array()/array_intersect() scans.
$rulesetAllowedLayerMaps = [];

foreach ($ruleset as $rulesetLayer => $allowedLayers) {
$rulesetAllowedLayerMaps[$rulesetLayer] = array_fill_keys($allowedLayers, true);
}

$classViolationSkipMaps = [];

foreach ($architecture->getClassViolationSkips() as $skipClassName => $skippedDependencies) {
$classViolationSkipMaps[$skipClassName] = array_fill_keys($skippedDependencies, true);
}

$rulesetSkipPaths = $this->mergedSkipPaths($globalSkipPaths, $architecture->getRulesetSkipPaths());
$rulesetSkipPathMatcher = SkipPathMatcher::compile($this->basePath, $rulesetSkipPaths);
$rulesetViolationCollection = new RuleViolationCollection();
Expand Down Expand Up @@ -272,14 +285,14 @@ className: $violation->className,
continue;
}

$allowedLayers = $ruleset[$classNode->layer] ?? null;
$allowedLayerMap = $rulesetAllowedLayerMaps[$classNode->layer] ?? null;

if ($allowedLayers === null) {
if ($allowedLayerMap === null) {
// Layer not listed in ruleset — no restriction.
continue;
}

$skippedDepsForClass = $classViolationSkips[$classNode->className] ?? [];
$skippedDepsForClass = $classViolationSkipMaps[$classNode->className] ?? [];
$dependencies = $this->dependenciesForClass(
$classNode->className,
$dependencyMap,
Expand All @@ -288,7 +301,7 @@ className: $violation->className,
);

foreach ($dependencies as $dependency) {
if (in_array($dependency, $skippedDepsForClass, true)) {
if (isset($skippedDepsForClass[$dependency])) {
continue;
}

Expand Down Expand Up @@ -322,8 +335,10 @@ className: $violation->className,

// A dependency is permitted when any of its layers is explicitly allowed,
// regardless of whether the dependency was scanned or regex-resolved.
if (array_intersect($allowedLayers, $depLayers) !== []) {
continue;
foreach ($depLayers as $depLayer) {
if (isset($allowedLayerMap[$depLayer])) {
continue 2;
}
}

$violatingLayer = $primaryLayer ?? $depLayers[0];
Expand Down
Loading