fix(popup): portal annotation popup toolbar and reply so it stays upright on rotate#749
Merged
kduncanhsu merged 3 commits intoMay 14, 2026
Merged
Conversation
|
Duncan Hsu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
b3d3cb2 to
39f1a7e
Compare
jackiejou
reviewed
May 12, 2026
c67e8cc to
7391fed
Compare
7391fed to
d0559fb
Compare
jackiejou
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PopupDrawingToolbarandPopupReplyto thepopupPortalElcontainer (outside the rotating.ba-Layer) so they remain upright when the page is rotated, matching the existingPopupV2approachPopupDrawingToolbarPopper.js options so the toolbar correctly follows its annotation on scroll and doesn't stick to the viewport edgeDeselectListenerfrom deselecting annotations when clicking portaled popup elementsDetails
When the page is rotated, annotation layers receive
transform: rotate(Xdeg), causing all children to rotate.PopupV2already solved this via portaling, butPopupDrawingToolbarandPopupReplystill rotated with their layers.Portaling changes:
Stacking context fix:
Popper.js behavioral fixes:
Deselect fix:
Test plan