fix(tracing): stop marking successful tool calls as errors - #71
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoSep 11, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41ef1e401f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Claude treated Bash stderr and TaskStop success messages as failure diagnostics.
Require a native failure signal before setting `error`. Ignore null, false, or
blank Codex error members while preserving nonempty structured error markers.
Before:
{"output":{"message":"Successfully stopped task"},"error":"Successfully stopped task"}
After:
{"output":{"message":"Successfully stopped task"}}
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-fix-successful-tools-marked-errors
branch
from
September 11, 2026 19:09
41ef1e4 to
e51223f
Compare
Andrew Kent (realark)
approved these changes
Sep 11, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-fix-successful-tools-marked-errors
branch
September 11, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/braintrustdata/issue/SDK-344/successful-tool-calls-populate-the-error-field
We were always recording an error for claude code, which is wrong. While we here, ignore empty error members in structured Codex output.
Before:
After: