Skip to content

support more formats in attachment processor #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Kent (realark) merged 4 commits into from
May 19, 2026
Merged

support more formats in attachment processor #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74235c1
clean up test harness resources upon garbage collection
realark May 15, 2026
4cee146
bump sdk spec test version
realark May 18, 2026
9c3347f
update anthropic stream span names to match sdk spec
realark May 18, 2026
04b0ceb
add attachment processor support for aws, anthropic, and google
realark May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...rc/test/java/dev/braintrust/instrumentation/anthropic/v2_2_0/BraintrustAnthropicTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ void testWrapAnthropic() {
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals("anthropic.messages.create", span.getName());
assertFalse(span.getName().isEmpty(), "span name should be non-empty");
Copy link
Copy Markdown
Collaborator Author

@realark Andrew Kent (realark) May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making assertion less specific because spec tests will assert on the particular name


// Verify span_attributes
String spanAttributesJson =
Expand Down Expand Up @@ -156,7 +156,7 @@ void testWrapAnthropicStreaming() {
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals("anthropic.messages.create", span.getName());
assertFalse(span.getName().isEmpty(), "span name should be non-empty");

// Verify metadata
String metadataJson =
Expand Down Expand Up @@ -220,7 +220,7 @@ void testWrapAnthropicAsync() {
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals("anthropic.messages.create", span.getName());
assertFalse(span.getName().isEmpty(), "span name should be non-empty");

String spanAttributesJson =
span.getAttributes().get(AttributeKey.stringKey("braintrust.span_attributes"));
Expand Down Expand Up @@ -290,7 +290,7 @@ void testWrapAnthropicAsyncStreaming() {
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals("anthropic.messages.create", span.getName());
assertFalse(span.getName().isEmpty(), "span name should be non-empty");

assertNotNull(span.getAttributes().get(AttributeKey.stringKey("braintrust.input_json")));

Expand Down Expand Up @@ -342,7 +342,7 @@ void testWrapAnthropicBeta() {
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals("anthropic.messages.create", span.getName());
assertFalse(span.getName().isEmpty(), "span name should be non-empty");

// Verify span_attributes
String spanAttributesJson =
Expand Down Expand Up @@ -431,7 +431,7 @@ void testWrapAnthropicBetaStreaming() {
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals("anthropic.messages.create", span.getName());
assertFalse(span.getName().isEmpty(), "span name should be non-empty");

// Verify metadata
String metadataJson =
Expand Down
16 changes: 16 additions & 0 deletions braintrust-sdk/src/main/java/dev/braintrust/instrumentation/InstrumentationSemConv.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ private static void tagAnthropicRequest(

if (requestBody != null) {
JsonNode requestJson = BraintrustJsonMapper.get().readTree(requestBody);
if (requestJson.has("stream")
&& requestJson.get("stream").isBoolean()
&& requestJson.get("stream").asBoolean()) {
span.updateName(getStreamingSpanName(providerName, pathSegments));
}
if (requestJson.has("model")) {
metadata.put("model", requestJson.get("model").asText());
}
Expand Down Expand Up @@ -503,4 +508,15 @@ private static String getSpanName(String providerName, List<String> pathSegments
default -> lastSegment;
};
}

private static String getStreamingSpanName(String providerName, List<String> pathSegments) {
if (pathSegments.isEmpty()) {
return UNSET_LLM_SPAN_NAME;
}
String lastSegment = pathSegments.get(pathSegments.size() - 1);
return switch (providerName + ":" + lastSegment) {
case PROVIDER_NAME_ANTHROPIC + ":messages" -> "anthropic.messages.stream";
default -> getSpanName(providerName, pathSegments);
};
}
}
Loading
Loading