feat(bundler-plugins): Add braintrust{Bundler}Plugin aliases for bundler plugins and deprecate rest#2032
Conversation
…ndler plugins and deprecate rest
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "name": "@braintrust/vitest-wrapper-tests", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Snuck these changes in because these packages were polluting pnpm run changeset output and the only way to prevent that is by not giving the packages version numbers.
Also it's one extra safeguard to not accidentally publish these packages I guess.
| /** ISO-8601 timestamp when the cassette was first created. */ | ||
| createdAt: string; | ||
| /** The seinfeld version that produced the cassette. */ | ||
| seinfeldVersion: string; |
There was a problem hiding this comment.
we also gotta update dev-packages/seinfeld/src/format/v1.ts
There was a problem hiding this comment.
Good catch, the rabbit hole went even deeper cad5d4a
| "braintrust": minor | ||
| --- | ||
|
|
||
| feat(bundler-plugins): Add `braintrust{Bundler}Plugin` aliases for bundler plugins and deprecate rest |
There was a problem hiding this comment.
I'd be more explicit here and list all the exports that were renamed.
| * defaults to browser-compatible diagnostics channel shimming when `browser` | ||
| * is omitted; `braintrustEsbuildPlugin` defaults to Node.js diagnostics_channel | ||
| * unless `useDiagnosticChannelCompatShim` is set to `true`. |
There was a problem hiding this comment.
feel like this stuff doesn't really matter to the user. I'd just remove the diagnostics channel note all together. Or word it to be more clear about user impact
There was a problem hiding this comment.
Yeah, agree. Will remove.
| * | ||
| * @default false | ||
| */ | ||
| useDiagnosticChannelCompatShim?: boolean; |
There was a problem hiding this comment.
should this be a top level option? Or can we prefix with internal or similar to make it more clear that most users shouldn't really mess with this?
There was a problem hiding this comment.
This is not an internal option, also I don't fully like steering users away from an option. Technically very valid to use if they are on cloudflare or whatever.
2 participants
Reason: In the context of a vite config, it makes no sense to have a vite plugin named
vitePlugin. There is an argument to be made around calling itbraintrustPlugin, however I imagine agents have a better time understanding and importing stuff when the different plugins are actually named differently.Also the default value of the
browseroption is insane since we don't even have a working browser sdk.