Skip to content

fix(js): support /v1/embeddings endpoint in OpenAI batch instrumentation (#2425) #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohd Quamar Tyagi (Tyagiquamar) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(js): support /v1/embeddings endpoint in OpenAI batch instrumentation (#2425) #2478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions js/src/instrumentation/plugins/openai-batch-instrumentation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,4 +394,33 @@ describe("OpenAI Batch instrumentation", () => {
expect(received).toBe(content);
expect(await backgroundLogger.drain()).toEqual([]);
});

it("supports /v1/embeddings batch requests", async () => {
const embeddingsInput = [
{
custom_id: "emb1",
method: "POST",
url: "/v1/embeddings",
body: {
model: "text-embedding-3-small",
input: "hello world",
},
},
];

let received = "";
const result = await openaiFilesCreateTraced({
create(params: { file: Blob; purpose: string }) {
return asyncAPIPromise(
Promise.resolve({ id: "file_emb" }).then(async (file) => {
received = await params.file.text();
return file;
}),
);
},
})({ file: new Blob([jsonl(embeddingsInput)]), purpose: "batch" });

expect(result).toEqual({ id: "file_emb" });
expect(received).toBe(jsonl(embeddingsInput));
});
});
6 changes: 5 additions & 1 deletion js/src/instrumentation/plugins/openai-batch-instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ import {
processImagesInOutput,
} from "./openai-span-data";

const SUPPORTED_ENDPOINTS = new Set(["/v1/chat/completions", "/v1/responses"]);
const SUPPORTED_ENDPOINTS = new Set([
"/v1/chat/completions",
"/v1/responses",
"/v1/embeddings",
]);
const TERMINAL_STATUSES = new Set([
"completed",
"failed",
Expand Down