fix: Use POSIX redirect in pre-commit gitleaks guard - #2486
Merged
Merged
Conversation
`&> /dev/null` is a bashism. Husky runs hooks under `/bin/sh`, so on systems where that is dash the guard parsed as a backgrounded `command -v gitleaks &` followed by a bare `> /dev/null` redirection, whose exit status is always 0. That made the `if` always true, so `gitleaks protect` ran even when gitleaks was not installed and the warning branch was unreachable. This was failing on CI with Linux runners.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&> /dev/nullin.husky/pre-commitis a bashism. Husky runs hooks under/bin/sh, so on systems where that is dash (Linux CI runners) the guard parses as a backgroundedcommand -v gitleaks &followed by a bare> /dev/nullredirection, whose exit status is always 0. Theifis therefore always true:gitleaks protectruns even when gitleaks is not installed, and the warning branch is unreachable. This was failing on CI with Linux runners.Verified with the dash on macOS:
After the change, running the hook under dash with gitleaks absent takes the else branch and prints the intended warning.