Skip to content

fix: handle RemoteEvalParameters in eval dev /list endpoint #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Alex Jean-Baptiste (justcodebruh) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: handle RemoteEvalParameters in eval dev /list endpoint #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/eval-runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
set_thread_pool_max_workers,
)
from braintrust.logger import Dataset, init as init_logger_experiment, parent_context, _internal_get_global_state
from braintrust.parameters import parameters_to_json_schema, validate_parameters
from braintrust.parameters import RemoteEvalParameters, parameters_to_json_schema, validate_parameters
from braintrust.util import eprint
from braintrust.span_identifier_v4 import parse_parent
except Exception as exc: # pragma: no cover - runtime guard
Expand Down Expand Up @@ -566,8 +566,14 @@ def build_eval_definitions(evaluator_instances: list[EvaluatorInstance]) -> dict
for evaluator_instance in evaluator_instances:
evaluator = evaluator_instance.evaluator
scores = [{"name": getattr(score, "__name__", f"scorer_{i}")} for i, score in enumerate(evaluator.scores)]
if isinstance(evaluator.parameters, RemoteEvalParameters):
parameters_schema: dict[str, Any] = evaluator.parameters.schema or {}
elif evaluator.parameters:
parameters_schema = parameters_to_json_schema(evaluator.parameters)
else:
parameters_schema = {}
definitions[evaluator.eval_name] = {
"parameters": parameters_to_json_schema(evaluator.parameters) if evaluator.parameters else {},
"parameters": parameters_schema,
"scores": scores,
}
return definitions
Expand Down
Loading