Repository navigation
release: 1.12.0 — dark-surface colors for links, h6, code and mark (#23) - #25
Merged
Merged
Conversation
Dark-surface colors for links, h6, code and mark (#23). hyper_render requires hyper_render_core ^1.12.0 (StyleResolver.darkSurface). hyper_render_epub 0.1.3, hyper_render_clipboard 1.7.3 and the other packages are unchanged and need no release. CHANGELOG headings, README, MIGRATION_GUIDE, CSS matrix and roadmaps updated.
Contributor
|
| Fixture | Budget (ms) | Median (ms) | P95 (ms) | |
|---|---|---|---|---|
| ❌ | simple_paragraph |
8 | 17 | 25 |
| ❌ | mixed_inline |
10 | 15 | 16 |
| ❌ | float_layout |
12 | 17 | 30 |
| ❌ | table_20_rows |
14 | 49 | 65 |
| ✅ | cjk_ruby |
14 | 10 | 12 |
| ❌ | large_article |
16 | 37 | 67 |
One or more fixtures exceeded the 16 ms budget.
Flutter
3.41.5· ubuntu-22.04
Informational, does not block merge: CI runners use software
rendering and are 2-3x slower than the devices the budgets are
calibrated for. Compare against the base branch; if a fixture
regressed relative to it, profile with:
flutter test benchmark/layout_regression.dart --reporter expandedand check _performLineLayout / _buildCharacterMapping for
any new O(N²) or O(N log N) paths introduced in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and docs for 1.12.0. The code was reviewed and merged in #24 (CI green incl. Golden; main CI matrix green on d8262e1).
hyper_render_corehyper_render^1.12.0)hyper_render_epubHyperViewer, picks the change up automatically)Changes: pubspec versions and core constraint; CHANGELOG headings (
Unreleased→1.12.0); README, MIGRATION_GUIDE (new "Upgrading to v1.12.0"), CSS matrix, both roadmaps.Verification on this branch: root+core 2513 pass, epub 53, analyze and format clean, core dry-run publish OK.