fix: surface unhandled native result statuses on the query callback - #3765
Open
official-burak wants to merge 1 commit into
Open
fix: surface unhandled native result statuses on the query callback#3765official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Unhandled libpq statuses never reached the query callback, so callers saw undefined instead of the server error.
brianc
reviewed
Sep 10, 2026
brianc
left a comment
brianc
left a comment
Owner
There was a problem hiding this comment.
I appreicate the PR! I am curious if there's a way you can write an integration test that actually hits a postgres backend to go through the error path vs. just relying on stubs & unit tests to stress the behavior? I appreciate the tests, but sometimes there can be a situation in which too many things are mocked & the actual error can get re-introduced if the internals change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the careful write-up in #3758. COPY through the native client, and other unhandled libpq statuses, finished with no result object, so the query callback looked like success while
reswas undefined. The server error never reached that callback, which made the aborted transaction hard to explain.This emits a Result for COPY statuses, matching the JS driver, and reports unrecognized statuses on the query itself. NativeQuery also treats a missing result as an error instead of success.
Fixes #3758