fix: drop 32-bit architecture support#556
Merged
Merged
Conversation
32-bit architecture (x32/i686) is not a valid return value from os.arch() in practice. The only GitHub Actions runner with a 32-bit architecture is Linux ARM, but Microsoft Edge does not distribute builds for Linux 32-bit ARM. Keeping the mapping was misleading and could result in a silent lookup failure. Remove the I686 arch constant, the x32 detection branch in getArch(), and the x86 API mapping so unsupported architectures now fail fast with a clear error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
32-bit architecture (x32/i686) is not a valid return value from
os.arch()on any GitHub Actions runner in practice. The only runner that could theoretically report a 32-bit architecture is Linux ARM, but Microsoft Edge does not distribute builds for Linux 32-bit ARM, so the mapping would always result in a silent lookup failure anyway. Removing it makes unsupported architectures fail fast with a clear error.