Skip to content

fix(percy): float @percy/webdriverio to ^3.3.4 (SDK-7711) - #228

Merged
Dalwin-Barnard merged 3 commits into
mainfrom
fix/sdk-7711-percy-webdriverio-unpin
Sep 29, 2026
Merged

Dalwin-Barnard merged 3 commits into
mainfrom
fix/sdk-7711-percy-webdriverio-unpin

Conversation

@rounak610

@rounak610 rounak610 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

What is this about?

Floats @percy/webdriverio from the temporary >=3.3.0 <3.3.3 pin to ^3.3.4.

The pin was introduced in the previous release (#210) as a workaround: @percy/webdriverio@3.3.3 shipped without its _iframe_shim.js file (it was never listed in package.json files), so the package failed to load with MODULE_NOT_FOUND and Percy web snapshots were silently disabled on WebdriverIO. Percy has fixed the packaging in 3.3.4 (percy/percy-webdriverio#1494, released 2026-09-24, now latest) and added a CI npm pack + clean-install smoke test to prevent recurrence, so the cap is no longer needed.

Only the version range changes; the lockfile resolves @percy/webdriverio@3.3.4 (with its @percy/sdk-utils@^1.32.0 transitive). No source changes.

Related Jira task/s

  • SDK-7711
  • Percy tracking: PER-10878 (closed) / SDK-7756 / PPLT-6128

Release (mandatory for every PR — required for the ready-for-review label)

Version bump: (required — tick exactly one)

  • minor (backwards-compatible feature)
  • patch (bug fix or other small change)

Release notes type: (optional)

  • New Feature
  • Bug Fix
  • Other Improvement

Release notes (customer-facing): (optional but encouraged)

  • Restored Percy visual snapshots on WebdriverIO by picking up the fixed @percy/webdriverio@3.3.4.

Release notes (internal): (required — engineer-facing; what actually changed / why)

  • Removed the temporary @percy/webdriverio >=3.3.0 <3.3.3 cap and floated to ^3.3.4; 3.3.3 was unloadable (missing _iframe_shim.js in the published tarball), fixed by Percy in 3.3.4. Lockfile updated to resolve 3.3.4 + @percy/sdk-utils@1.32.10.

Checklist

  • Ready to review
  • Has it been tested locally?

PR Validations

Run Tests: Comment RUN_TESTS to trigger sanity tests.

Removes the temporary >=3.3.0 <3.3.3 pin now that Percy has fixed the
broken 3.3.3 packaging (missing _iframe_shim.js) in 3.3.4. Restores Percy
web snapshot capture on WebdriverIO without the version cap.

SDK-7711

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rounak610
rounak610 requested a review from a team as a code owner September 24, 2026 12:28
@rounak610
rounak610 requested review from 07souravkunda and pranay-v29 and removed request for a team September 24, 2026 12:28
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 5b3184b2-18db-4aca-9bbb-70f0625f966f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

pranay-v29
pranay-v29 previously approved these changes Sep 24, 2026
@rounak610

Copy link
Copy Markdown
Collaborator Author

RUN_TESTS

@rounak610

Copy link
Copy Markdown
Collaborator Author

RUN_TESTS

@github-actions

Copy link
Copy Markdown
Contributor

🔴 SDK PR Review gate is red. Pending:

  • The SDK PR Review Agent has not been run on the current head commit yet — run the SDK PR Review Agent (its verdict is advisory; this gate only requires that it ran on the latest commit).

It turns green once the SDK PR Review Agent has run on the current head commit (any verdict — the gate only requires that the review ran). A native reviewer approval is separately required by branch protection before merge.

@rounak610

rounak610 commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator Author

⚠️ Needs human review

Summary: Floats @percy/webdriverio from >=3.3.0 <3.3.3 to ^3.3.4 (Percy's 3.3.3 packaging fix). package-lock.json regenerated to match. No source/logic changes. 0 blocking findings.

Per-File Confidence

File Status Reason
packages/browserstack-service/package.json ✅ All Clear Reviewed against config, default, external, integration, observability packs + the wdio-service card — dependency bump matches its own changeset and PR description (CF-01/CF-06 pinned-bump exemption); no findings

Not covered this run (coverage gap):

Region Why unjudged
.changeset/pr-228.md#h1 Skipped as unchanged since the prior review (content fingerprint identical to the run on commit 1a103aaa)
package-lock.json#h1..h4 Lockfile regions are excluded from unit review by design (generated file, context-only)

The ⚠️ verdict is driven entirely by this coverage gap, not by any suspected defect — the reviewed region (package.json) came back clean.

Process integrity

The review gate could NOT certify this run — the verdict is held at ⚠️ pending regardless of findings:

  • G3 — u001: no full read receipt for pack:docs
  • G3 — u001: no full read receipt for slice

Change map (generated deterministically from the diff)

graph LR
  subgraph nwdio_service["wdio-service"]
    n_changeset_pr_228_md["pr-228.md<br/>~5 lines"]
    npackages_browserstack_service_package_json["package.json<br/>~2 lines"]
  end
Loading

↻ This verdict comment is the review anchor — it's updated in place on each run (the gate posts its status separately).

— SDK PR Review Agent

@github-actions

Copy link
Copy Markdown
Contributor

🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: pending).

This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge.

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: pending).

This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge.

@rounak610

Copy link
Copy Markdown
Collaborator Author

RUN_TESTS

@rounak610
rounak610 changed the base branch from release_9.37.0 to main September 28, 2026 07:08
@rounak610
rounak610 dismissed stale reviews from harshit-browserstack and pranay-v29 September 28, 2026 07:08

The base branch was changed.

@rounak610

Copy link
Copy Markdown
Collaborator Author

RUN_TESTS

@github-actions

Copy link
Copy Markdown
Contributor

🔴 SDK PR Review gate is red. Pending:

  • The SDK PR Review Agent has not been run on the current head commit yet — run the SDK PR Review Agent (its verdict is advisory; this gate only requires that it ran on the latest commit).

It turns green once the SDK PR Review Agent has run on the current head commit (any verdict — the gate only requires that the review ran). A native reviewer approval is separately required by branch protection before merge.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: pending).

This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge.

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: pending).

This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: pending).

This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge.

@rahulpsq

Copy link
Copy Markdown
Contributor

RUN_TESTS

@rounak610

Copy link
Copy Markdown
Collaborator Author

@Dalwin-Barnard

Copy link
Copy Markdown
Contributor

RUN_TESTS

@Dalwin-Barnard
Dalwin-Barnard merged commit 59f32f6 into main Sep 29, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants