Merge LCAM-1282-fix-test-metadata-uuid-fallback - #250
Merged
Dalwin-Barnard merged 4 commits intoSep 29, 2026
Merged
Conversation
…CAM-1282)
setTestMetadata() is called before the test-run uuid is assigned, so only
fallbackMetadata gets populated and metadataByTestRunUuid stays empty.
testHubModule reads it back with TestMetadata.get(uuid), which has returned
{} since the fallback was removed — so app_lcnc was dropped from the
outgoing TestRun event and App LCA test runs never got linked to TestHub.
A per-uuid lookup now falls back to the current-run metadata only when no
per-uuid metadata has been recorded at all. Once per-uuid tracking is
active, an unknown uuid still returns {}, so one test run's metadata can
never leak into another.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Replaces the guarded variant with the exact restore of the clause removed in aa8898f: metadataByTestRunUuid[testRunUuid] || fallbackMetadata || {} testHubModule calls TestMetadata.reset() after each test completes, and that is what bounds reuse across runs, so the plain restore is sufficient and keeps get(uuid) consistent with the no-arg get(). Tests updated to assert the restored semantics, plus a new case covering that reset() between tests prevents a previous run's metadata being served. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…1282)
The failure this PR fixes was silent end to end: setTestMetadata stored
only the fallback, get(uuid) returned {}, and app_lcnc was omitted from
the event with nothing logged anywhere.
Adds two debug lines, both after the app_lcnc gate so they stay silent
for every other SDK consumer:
setTestMetadata: identifier=... storedUnderUuid=... store=[...]
TestMetadata.get: uuid=... identifier=... store=[...]
storedUnderUuid=undefined with store=[] identifies the ordering directly,
and identifier=undefined on the get line is the failure signature.
Also warns when setTestMetadata is called by a non-app_lcnc central user,
which previously returned silently.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bsautomation
requested review from
07souravkunda and
shivam5643
and removed request for
a team
September 29, 2026 13:21
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge into sdk_v8_pre_prod :by automationbs