Fix/sdk 4165 build identifier dropped when build name env set (drop) - #254
Closed
harshit-browserstack wants to merge 6 commits into
Closed
harshit-browserstack wants to merge 6 commits into
harshit-browserstack wants to merge 6 commits into
Conversation
_handleBuildIdentifier skipped buildIdentifier resolution whenever
BROWSERSTACK_BUILD_NAME was set, even though a buildName was available.
The skip also deleted buildIdentifier from the capabilities only — this
._buildIdentifier kept the unresolved '#${BUILD_NUMBER}' template, which
onPrepare forwards to TestHub as build_identifier.
Consequence: successive runs sharing a build name were never
disambiguated, so their sessions collapsed into a single build.
The guard now keys solely on the absence of a buildName, which is what
its own warning always claimed and what the binary's handleBuildIdentifier
already does (its BROWSERSTACK_BUILD_NAME skip is commented out). The
skip path additionally clears _buildIdentifier so the raw template is
never reported as a value.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…uild-name-env-set
Drop branch per the SDK release workflow (Handling Conflicts with sdk_pre_prod, Approach 1). The conflict is with #251 (SDK-4748), which already contains the SDK-4165 fix: BROWSERSTACK_BUILD_NAME no longer drops a configured buildIdentifier, and this._buildIdentifier is cleared when buildName is absent. - launcher.ts: take sdk_v9_pre_prod (#251), a superset of this branch's change. - launcher.test.ts: take #251's tests for the shared case and keep this branch's two additional cases (BUILD_NUMBER resolution with BROWSERSTACK_BUILD_NAME set; no unresolved template retained in memory). - drop .changeset/pr-192.md; the drop PR generates its own changeset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
harshit-browserstack
requested review from
vivianludrick and
yashdsaraf
and removed request for
a team
September 29, 2026 14:31
harshit-browserstack
added
the
skip-changeset
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Drop branch for #253 (
fix/sdk-4165-build-identifier-dropped-when-build-name-env-set→sdk_v9_pre_prod), which conflicts withsdk_v9_pre_prod. Raised per the SDK Release Workflow, Handling Conflicts with sdk_pre_prod, Approach 1. The original feature branch is untouched.sdk_v9_pre_prodon 2026-09-29). Merge fix/SDK-4748-build-identifier-precedence #251 already contains the SDK-4165 fix:BROWSERSTACK_BUILD_NAMEno longer discards an explicitly configuredbuildIdentifier, andthis._buildIdentifieris cleared when there is nobuildName. On top of that it addsBROWSERSTACK_BUILD_IDENTIFIER/BROWSERSTACK_BUILD_RUN_IDENTIFIERprecedence.src/launcher.ts: tooksdk_v9_pre_prod's version (Merge fix/SDK-4748-build-identifier-precedence #251), which is a superset of this branch's one-line change.tests/launcher.test.ts: took Merge fix/SDK-4748-build-identifier-precedence #251's tests for the case both branches covered, and kept this branch's two additional cases:${BUILD_NUMBER}still resolves whenBROWSERSTACK_BUILD_NAMEis set andbuildNameis in caps, and no unresolved${BUILD_NUMBER}template is left inthis._buildIdentifierwhen the identifier is skipped (it is forwarded to TestHub asbuild_identifier)..changeset/pr-192.mdis not carried over. Net ofsdk_v9_pre_prodthis PR only adds tests, and the behaviour ships with Merge fix/SDK-4748-build-identifier-precedence #251's changeset, so it is labelledskip-changeset.Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
sdk_v9_pre_prodconflict with Merge fix/SDK-4748-build-identifier-precedence #251 (SDK-4748) by taking Merge fix/SDK-4748-build-identifier-precedence #251'slauncher.ts(it already contains the SDK-4165 fix) and adds two_handleBuildIdentifiertests (BUILD_NUMBER resolution withBROWSERSTACK_BUILD_NAMEset; no unresolved template retained). Test-only net ofsdk_v9_pre_prod.Checklist
Local, on the merged result:
tsc --noEmitclean. Intests/launcher.test.ts, all 5_handleBuildIdentifierbuild-identifier cases pass (#251's three plus this branch's two); the only failures are the two_uploadApptests, which fail identically onmain.PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code