fix(deps): raise chalk floor to ^5.6.2 to exclude malicious 5.6.1 (GHSA-2v46-p5h4-248w) - #255
kamal-kaur04 wants to merge 2 commits into
Conversation
chalk@5.6.1 was published by a hijacked maintainer account (GHSA-2v46-p5h4-248w / MAL-2025-46969). chalk is an external runtime dependency of the service, so consumers resolve it against our declared range; ^5.3.0 still admits 5.6.1 from any mirror or cache that retained it. The lockfile already resolves 5.6.2, so the installed tree is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
RUN_TESTS |
|
No code defects found in the reviewed changes. The One region could not be reviewed automatically: the matching range line in
Change map (generated deterministically from the diff)graph LR
subgraph nnode_agent["node-agent"]
n_changeset_pr_255_md["pr-255.md<br/>~5 lines"]
npackages_browserstack_service_package_json["package.json<br/>~2 lines"]
end
↻ This verdict comment is the review anchor — it's updated in place on each run (the gate posts its status separately). — SDK PR Review Agent |
|
Lockfile check on head 706da2a (the region the automated review skipped): the only |
|
|
|
RUN_TESTS |
|
🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge. |
1 similar comment
|
🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge. |
|
[SDK Wdio Test] TRA build state: passed | Stability 100% — verdict: success. Passed: 51, Failed: 0, Aggregate: 51. TRA: https://observability.browserstack.com/builds/yqdauqadubc5j16rknzieefndvyfyg47obyzxybo |
|
🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge. |
1 similar comment
|
🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge. |
What is this about?
Raises the
chalkdependency floor of@wdio/browserstack-servicefrom^5.3.0to^5.6.2so the range can no longer resolvechalk@5.6.1, the version published by a hijacked maintainer account in the September 2025 npm supply-chain attack (GHSA-2v46-p5h4-248w / MAL-2025-46969).chalkis keptexternalin the esbuild bundle, so consumers resolve it against this package's declared range. npm has unpublished 5.6.1, but a registry mirror or cache that kept it could still serve it for^5.3.0. The lockfile already resolves5.6.2, so the installed tree is unchanged. The only change is the range inpackage.jsonplus the matching lockfile line.Verified locally:
npm ci+npm ls chalk --all(only 5.6.2 / 4.1.2, no 5.6.1),npm run buildpasses,npm testshows 59 files / 1345 tests passing.Related Jira task/s
N/A (tracked internally). Advisory: GHSA-2v46-p5h4-248w
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
chalkversion to 5.6.2 so installs can never resolve the compromisedchalk@5.6.1(GHSA-2v46-p5h4-248w).Release notes (internal): (required — engineer-facing; what actually changed / why)
chalkrange^5.3.0→^5.6.2inpackages/browserstack-service/package.json(+ lockfile range line); resolved version unchanged at 5.6.2. Thev8line carries the same^5.3.0range and needs the same bump.Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code