added MongoDB (new php driver mongodb) storage

[AstRonin]

No description provided.

[danopz]

Ah I've found that #697 adds this storage too

[AstRonin]

Brent has a choice :)

[bshaffer]

curly braces after function declarations should be on their own line, to be consistent with the styles in the rest of this library

[bshaffer]

This looks promising, but a few major things need to be fixed before we merge this.

1. Travis tests are failing because we need to add the mongodb.so extension in travis.yml.
2. You need to fix the line endings so the diffs accurately reflect the changes submitted by this PR. check out dos2unix or this SO article on how to remove the carriage returns.
3. What is the purpose of MongoDBTest? All these methods are covered by the standard storage suite of tests.

[AstRonin]

Ok, I will do the changes after my holidays.

1. I did not have to deal with travis.yml ... what I should do?
2. Yes, about newlines, I noticed after pushing...
3. I needed to make sure which methodes work (write/read/remove) as I expected in different situations. For example, method \OAuth2\Storage\Mongo::setRefreshToken does insert instead of update and it looks like a bug. Standart tests don't identify it.

Another thing is that I can change [] to array() in Bootstrap.php for maintain a common style but we cannot use new MongoDB driver with php v5.3

[bshaffer]

@AstRonin Sounds good! Okay, to address your questions:

1. To deal with travis.yml, add the following lines to before_install:

   before_install:
   - if [[ ${TRAVIS_PHP_VERSION:0:3} == "7.0" ]]; then
       phpenv config-add testing/mongodb.ini;
     elif [[ ${TRAVIS_PHP_VERSION:0:3} != "5.3" ]]; then
       pecl install mongodb || /bin/true;
     fi

2. great!

3. Ok I get it. If there's a way to test all storage classes for this, that would be best. If it's a mongodb-specific thing to test, then this works great. We should remove duplicate tests though.

4. This is no problem! Have Bootstrap::getMongoDB use NullStorage in this case, and the tests will be skipped:

   if ('5.3' === substr(phpversion(), 0, 3)) {
       $this->mongodb = new NullStorage('MongoDB', 'The mongodb.so extension is not compatible with PHP 5.3');
   }

[AstRonin]

I added new commit, but travis failed again...

[scaleupcto]

Test fails because Call to undefined method MongoDB\Driver\Manager::setAuthorizationCode() in /home/travis/build/bshaffer/oauth2-server-php/test/OAuth2/OpenID/Storage/AuthorizationCodeTest.php on line 77.

I think you need to be more specific here and use the namespace new \OAuth2\Storage\ MongoDB because the error suggests you are trying to call the setAuthorizationCode on the underlying MongoDB driver class, which obv won't work.

[AstRonin]

ok, it's my fault, I mixed classes in Bootstrap in previous test...
Now error only for :

• PHP 5.3 - MongoDB does not work in 5.3 at all, but Trevis parsed anyway...
• HHVM - Has no extension MongoDB

Will I need add something else in travis.yml?

[svycka]

php5.3 really? http://php.net/supported-versions.php

[AstRonin]

https://docs.mongodb.com/ecosystem/drivers/php/#language-compatibility
It discussed early

[scaleupcto]

HHVM works but you need the specific mongodb.so for that env.

[chadicus]

If anyone is interested, I created companion library over the weekend. https://github.com/chadicus/oauth2-storage-mongodb.
I also needed to use MongoDB for storage, but the current restrictions of this library, it was easier to create a separate storage implementation rather than try to get a PR approved here. As soon as this library ups its version of PHP, I'll be creating a PR.

Please keep in mind my mongodb library is in its very early stages and I'm sure it has bugs. I would not recommend for production use at this time.

[bshaffer]

Added in #790