Skip to content

chore: bump pnpm to 12.4.1 - #678

Merged
btravers merged 3 commits into
mainfrom
chore/pnpm-12.4.1
Sep 14, 2026
Merged

btravers merged 3 commits into
mainfrom
chore/pnpm-12.4.1

Conversation

@btravers

@btravers btravers commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bumps packageManager from pnpm 11.7.0 to 12.4.1 (major).

  • Lockfile regenerated with pnpm install --lockfile-only: the only change is pnpm 12's new packageManagerDependencies document pinning pnpm's own integrity. Dependency graph unchanged.
  • pnpm 12 breaking changes to watch in CI: unrecognized pnpm-workspace.yaml settings now error, --frozen-lockfile false removed (use --no-frozen-lockfile), stricter engineStrict.

https://claude.ai/code/session_01JqjTCSDPsbgreJKHcRABi9

Summary by CodeRabbit

  • Documentation

    • Updated development setup instructions to require pnpm 12.4.1.
  • Chores

    • Updated the project’s required package manager version to pnpm 12.4.1.

Copilot AI lite review requested due to automatic review settings September 14, 2026 22:44
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c95a2fff-f1ef-4ecd-bb73-9e52d751f732

📥 Commits

Reviewing files that changed from the base of the PR and between f68d4a3 and 278417c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (2)
  • CONTRIBUTING.md
  • pnpm-workspace.yaml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 769dfed7-7913-4e50-a3f0-065b46f03757

📥 Commits

Reviewing files that changed from the base of the PR and between 31f1d53 and f68d4a3.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (2)
  • CONTRIBUTING.md
  • package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The package manager requirement changes from pnpm 11.7.0 to 12.4.1. The contributing guide documents the same pnpm version.

Changes

pnpm Version Alignment

Layer / File(s) Summary
Update package manager requirement and documentation
package.json, CONTRIBUTING.md
The required pnpm version changes to 12.4.1 in package metadata and development setup instructions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: copilot

Merge Risk: ⚪ Minimal · up to f68d4

The pnpm upgrade remains compatible with the repository’s documented setup and CI installation path, with no confirmed merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating pnpm to version 12.4.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pnpm-12.4.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

pnpm-lock.yaml appears to contain two YAML documents (duplicated lockfile), which will likely break pnpm installs/CI until regenerated into a single valid lockfile.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR upgrades the repository’s pinned package manager to pnpm 12.4.1 (via packageManager) and updates contributor documentation accordingly, alongside an intended lockfile regeneration.

Changes:

  • Bumped packageManager in package.json from pnpm 11.7.0 to 12.4.1.
  • Updated CONTRIBUTING.md to reflect pnpm 12.4.1 in developer prerequisites.
  • Regenerated pnpm-lock.yaml, intending to include pnpm 12’s packageManagerDependencies metadata (but the current lockfile content appears to be malformed / duplicated).
File summaries
File Description
pnpm-lock.yaml Regenerated lockfile content; currently appears to include two YAML documents (likely breaking installs).
package.json Updates the pinned packageManager version to pnpm 12.4.1.
CONTRIBUTING.md Updates contributor prerequisites to reference pnpm 12.4.1 (and should align Node minimum with engines).
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file

Suppressed comments (1)

pnpm-lock.yaml:162

  • pnpm-lock.yaml appears to contain two YAML documents (a standalone pnpm 12 packageManagerDependencies doc, then a second full lockfile starting at the second ---). pnpm’s lockfile reader expects a single document; this will likely cause installs to read only the first doc and ignore the real dependency graph.
  • Files reviewed: 2/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CONTRIBUTING.md Outdated
Clears the high-severity advisories that fail CI's pnpm audit:
GHSA-2883-xcg3-v3hh (js-yaml <4.3.2) and, where present, the fast-uri
<3.1.6 advisories.

Claude-Session: https://claude.ai/code/session_01JqjTCSDPsbgreJKHcRABi9
@btravers
btravers merged commit 3a10e01 into main Sep 14, 2026
24 of 25 checks passed
@btravers
btravers deleted the chore/pnpm-12.4.1 branch September 14, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants