[pull] main from bulwarkmail:main - #65
Merged
Merged
Conversation
Two reporters on #843 filed it as a bug before clarified in the thread that an empty Unified Mailbox section is expected once none of its sub-features are on: the combined folder rows need 2+ connected accounts (or a group inbox), and All mail/Unread/Starred are each a separate admin policy gate.
…n't capped at five isHttp2Available() only inspected "resource" timing entries, which can be empty right after a fresh login or session restore, before any subresource finishes loading. On an HTTP/2 page this made getMaxAccounts() fall back to the HTTP/1.1 cap of five accounts. Include the "navigation" timing entry, whose nextHopProtocol is known immediately, so h2/h3 is recognized on first load. Environments without timing data still return false (no h2 assumed).
…ttachment list Some senders ship the images their HTML body embeds via cid: as application/octet-stream with no Content-Disposition and no filename. The body rendered them fine, but the "hide inline images" check only recognised parts declared inline with an image/* type, so they also showed up as nameless "Attachment" chips next to the real files. Both viewers now scan the HTML they actually render for cid: references (the same pattern the renderer rewrites to blob URLs) and hide a referenced part when it is an image or generically typed. An explicit attachment disposition always keeps its chip, as does a referenced part with a real non-image type, since that chip is its only download. Plain text rendering references nothing, so nothing is hidden there. The shared rule lives in lib/attachment-visibility.ts so the desktop viewer, the thread view and the decrypted-message path cannot drift apart.
…ccessibility fix(a11y): Improved accessibility of the email list
…parts fix: hide body-embedded cid parts declared as octet-stream from the attachment list
…unt-limit fix: detect HTTP/2 from the initial navigation timing so accounts aren't capped at five
…ox-empty-section docs: clarify why the Unified Mailbox section can look empty (#843)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )