Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I check https://img.shields.io/pypi/v/protovalidate, the image is orange. https://badge.fury.io/py/protovalidate.svg is green.
Does that indicate a problem/warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://shields.io/badges/py-pi-version, I don't think so; we can change the
color=querystring parameter if it matters much?I tend to look at attrs for guidance here as an established pypi project, and they seemingly have it blue, with the default value. I wonder if it's just because we're pre-1.0, or because we haven't set up trusted publishing yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to use the default — I just wanted to make sure the change wasn't indicative of a problem. Nothing 404s, I'll approve this just now.