Skip to content

Bug 681635: De-duplicate values in Advanced Search - #184

Merged
justdave merged 4 commits into
bugzilla:mainfrom
loganrosen:loganrosen-harmony-bug-681635
Sep 1, 2026
Merged

Bug 681635: De-duplicate values in Advanced Search#184
justdave merged 4 commits into
bugzilla:mainfrom
loganrosen:loganrosen-harmony-bug-681635

Conversation

@loganrosen

Copy link
Copy Markdown
Contributor

Details

Advanced Search can show duplicate version or target milestone values when selected products use configured ordering rather than case-insensitive alphabetical ordering. merge_arrays used a two-pointer merge that assumed both inputs were already sorted, so overlapping values at different positions were not recognized as duplicates.

This is the Harmony port of bugzilla/bugzilla#244. It combines both inputs, sorts them case-insensitively, and removes adjacent case-insensitive duplicates while preserving the incremental <select> options path. A Perl TAP regression executes the production JavaScript with Node. The dedicated release-test image installs and requires Node.js, while Node-less runtime and sanity images skip the test. Runtime images are unchanged.

Additional info

Test Plan

  1. Run bash docker/run-tests-in-docker.sh release; confirm all 28 files and 14,205 tests pass, including t/015productform.t.
  2. Run docker compose -f docker-compose.test-mysql.yml run --no-deps --rm bugzilla6.test test_sanity t/*.t extensions/*/t/*.t; confirm all 32 files and 14,229 tests pass, with t/015productform.t skipped in the intentionally Node-less image.
  3. Hide Node from the release image and confirm t/015productform.t fails because BZ_REQUIRE_NODE=1.

loganrosen and others added 4 commits August 29, 2026 19:11
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@justdave
justdave merged commit ffbdc92 into bugzilla:main Sep 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants