Integrate Anti-IF + Fowler principles: R11, R12, PREPARE phase, and the maxims layer

[buzzdan]

What

Five waves of principle integration, all following the rules-as-data architecture:

1. Anti-IF wave — the Anti-IF movement's core insight (Cirillo, 2007): the enemy is not if, it is the duplicated kind-conditional.
2. Fowler wave — the Refactoring (2nd ed.) ideas the rule set didn't already embody, centered on the Mutable Data smell family.
3. Preparatory refactoring — Fowler's highest-value trigger ("make the change easy, then make the easy change"), encoded as a fully autonomous workflow phase so autopilot never stops to ask.
4. The maxims layer — the uncompiled judgment above the rules: named design maxims as questions, wired into the judgment points and banned from the evidence path.
5. Finding clusters — design-first routing when independent hunters converge on one anchor: convergence is evidence of a missing domain concept, so the cluster gets one design instead of N partial fixes.

Go plugin → v2.6.0

New rule: rules/R11-conditional-dispatch.md (Anti-IF) — a conditional that asks what a value is may exist once; the second copy is a missing polymorphic type. Owns: Replace Duplicated Switch with Interface Dispatch (decision moves to a ParseX boundary constructor — R2's behavioral twin), Replace If-Chain with Strategy Map, Introduce Null Object, Split Flag Argument, and the sanctioned Keep the Single Exhaustive Switch (exhaustive linter proves completeness). Inverse trap: dispatch that deletes no duplication is ceremony.

New rule: rules/R12-mutation-discipline.md (Fowler's Mutable Data, with Go aliasing teeth) — a validated value changes state only through methods that own its invariants. In Go, return g.perms returns a mutable alias into the validated state — R2's validate-once guarantee is void the moment an internal slice escapes. Owns: Copy on the Way In, Copy on the Way Out / Encapsulate Collection (clones or iter.Seq), Separate Query from Modifier, Remove Setting Method, Split Variable. Inverse trap: ceremony copies of data that never escapes.

New phase: 1.5 PREPARE — autonomous preparatory refactoring. After design approval, the orchestrator surveys the plan's touch points with the existing rule detection greps and reshapes what the change is about to hit, before the first RED, in segregated prep commits. Four mechanical gates decide — MULTIPLY / SAFE / BOUNDED / SKEPTICIZED — so the loop emits a PREPARATION LOG as a record, never a question. A RED-friction escape hatch catches what the survey missed. Plus @refactoring <preparatory_mode> (stopping criterion: the feature lands add-only) and a standalone /go-ldd-prepare command.

New layer: maxims.md. Rules are compiled judgment (detection + criterion + fix); maxims are the named questions that generate such rules where none anticipated the situation — 18 entries (Tell-Don't-Ask, Law of Demeter, illegal-states-unrepresentable, parse-don't-validate, Metz's wrong-abstraction, YAGNI, three strikes, Pike's Go proverbs, Beck's change-easy, GOOS's listen-to-your-tests, Fowler's hurts-do-it-more, Knuth, once-and-only-once, depend-toward-stability, and the house maxim "Every indirection must earn its keep" — the generalized juiciness test, one principle at six granularities). The contract — maxims propose, evidence disposes — wires them into the three judgment points (@code-designing <maxim_interrogation>, @refactoring escalation vocabulary, the skeptic's named citations) and bans them from hunters, with a documented graduation path (a maxim that keeps convicting becomes an R-file — R11 is a graduate).

Finding clusters (review flow). @pre-commit-review's merge step gains a cluster pass: findings from ≥2 different rules converging on one anchor (same type, field, function) are reported as first-class 🔗 CLUSTER entries with a root-cause hypothesis — hunters are single-obsession and blind to each other, so convergence is independent confirmation of a missing concept. The orchestrator routes clusters design-first: @code-designing in a new cluster-scoped mode (skips the architecture scan and user-OK gate — acceptance inherited; designs only the concept the cluster names), then @refactoring implements the mini plan. Member-by-member fixing of clusters is explicitly forbidden — partial fixes undo each other.

New case law:

• examples/anti-if-dispatch.md — three-site channel switch (already drifted) → interface dispatch; the strategy-map variant; the worked juiciness rejection where the switch stays and goes exhaustive.
• examples/switch-to-polymorphism.md — the type-switch sibling (real production code): an already-polymorphic value un-dispatched by a field-unpacking type switch → fill-style interface method; the earned/sealed interface (R6); the dependency-direction rejection where the consumer owns the wire format and the switch stays as pure dispatch.

Existing-rule sharpenings (Fowler):

• R3 gains Split Phase (parse phase → intermediate structure → compute phase; collapses into R2's ParseX when phase 1 validates)
• R1 gains Introduce Parameter Object + a Data Clumps falsifying question
• R4 gains Move Method to the Envied Type + a Feature Envy falsifying question, plus the Message Chains ↔ Middle Man pair compiled to its post-Tell-Don't-Ask residue (a chain is a placement signal; a pure-forward method is R1's ceremony verdict per method; the domain-type embedding trap)

Wiring (one fact per fact): @refactoring routes exhaustive + discriminator-shaped dupl to R11 and indexes both rules' moves; lint-fixer's compact table kept consistent; @code-designing dispatches R11/R12 with checklist items; @pre-commit-review hunts both (🔴 Design Debt) and feeds R11 dispatch proposals to the skeptic with both case files as payload; README, CHANGELOG (2.2.0–2.6.0), manifests (10 → 12 rules).

TS/React plugin → v1.2.0

• @refactoring Pattern 8: Replace Tag-Based Conditionals with Dispatch — config/lookup maps (Record completeness), component maps over ternary chains in JSX, discriminated unions with never exhaustiveness checks
• @refactoring Pattern 9: Replace Loop with Pipeline — filter/map over accumulator loops, with guardrails against reduce abuse and async misuse
• @component-designing: one-dispatch-owner principle + pre-code review question

Notes

• Root README versions synced (2.6.0 / 1.2.0).
• No linters/tests run: the repo is markdown + JSON manifests only; JSON validity verified with python3 -c "json.load(...)".

🤖 Generated with Claude Code

https://claude.ai/code/session_01LeLyATJFYTLwWRrB5Vatfu

[buzzdan]

Added 015c6e9: a second R11 case file, examples/switch-to-polymorphism.md (real production code — the telemetry export converter).

It complements anti-if-dispatch.md rather than duplicating it:

• Different instance of the disease: not a raw kind-string duplicated across sites, but an already-polymorphic value un-dispatched by a field-unpacking type switch — the decision re-asked after construction already answered it.
• The tempting wrong fix, named: extracting each case body into a helper is the ceiling of function extraction, not the cure (the switch still grows; a forgotten case is still a silent no-op).
• Fill-don't-construct: fillUpdate(req *T) over ToUpdateRequest() when the output carries fields the variants don't own.
• A second rejection axis, orthogonal to Move 3's juiciness rejection: dependency direction — when the consumer owns the wire format, the dispatch move is physically unavailable (unexported output type / per-consumer method pollution) and the switch legitimately stays as pure dispatch.

Wiring: R11 Q2 sharpened (own-interface switches violate even at a single site; boundary exemption scoped to foreign output formats), two design-guidance bullets, fix-pattern + R6 earned-interface citations, refactoring case-law list, README, changelog.

Also fixed in passing: the R11 commit had accidentally deleted the ## [2.1.0] heading from the changelog, leaving R10's release notes floating inside the 2.2.0 entry — restored.

[Copilot]

Pull request overview

This PR expands the rules-as-data architecture for the Go plugin to include Anti-IF conditional dispatch (R11), mutation discipline (R12), an autonomous PREPARE phase for preparatory refactoring, a maxims layer for design-time interrogation, and cluster-based routing when multiple rules converge on the same anchor. It also updates the TS/React plugin with new refactoring patterns and bumps both plugins’ versions.

Changes:

• Add Go rules R11 (conditional dispatch) and R12 (mutation discipline), plus supporting case-law examples and wiring across skills/agents/commands.
• Introduce PREPARE (Phase 1.5) and cluster-based review routing, and add maxims.md as a judgment-only layer.
• Add TS/React refactoring patterns (tag-based conditional dispatch; loop → pipeline) and update plugin metadata/version references.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ts-react-linter-driven-development/skills/refactoring/SKILL.md	Adds Pattern 8 (dispatch) and Pattern 9 (pipeline) and routes them in the decision tree.
ts-react-linter-driven-development/skills/component-designing/SKILL.md	Adds Anti-IF “one dispatch owner” guidance and a pre-code review question.
ts-react-linter-driven-development/.claude-plugin/plugin.json	Bumps TS/React plugin version to 1.2.0.
README.md	Updates top-level plugin versions and expands rules list to R1–R12.
go-linter-driven-development/skills/refactoring/SKILL.md	Wires R11/R12 and adds preparatory refactoring mode guidance and references.
go-linter-driven-development/skills/pre-commit-review/SKILL.md	Adds R11/R12 hunting, skeptic payload changes, and cluster reporting semantics.
go-linter-driven-development/skills/linter-driven-development/SKILL.md	Adds Phase 1.5 PREPARE and RED-friction escape hatch + cluster routing.
go-linter-driven-development/skills/code-designing/SKILL.md	Dispatches into R11/R12 design guidance and adds maxim interrogation + cluster-scoped mode.
go-linter-driven-development/rules/R6-test-only-interfaces.md	Cross-links earned interface case law and references R11 discipline.
go-linter-driven-development/rules/R4-helper-placement.md	Adds Feature Envy / Message Chains / Middle Man guidance and a new falsifying question.
go-linter-driven-development/rules/R3-storifying.md	Adds Fowler “Split Phase” move guidance.
go-linter-driven-development/rules/R12-mutation-discipline.md	New rule defining mutation discipline for Go (aliasing-safe collections, no query/modifier hybrids, etc.).
go-linter-driven-development/rules/R11-conditional-dispatch.md	New rule defining Anti-IF conditional dispatch (single owner of discriminator inspection) and fix patterns.
go-linter-driven-development/rules/R1-primitive-obsession.md	Adds Introduce Parameter Object and data clumps falsifying question, renumbers inverse question.
go-linter-driven-development/README.md	Updates Go plugin architecture docs for maxims, R11/R12, PREPARE, and clusters.
go-linter-driven-development/maxims.md	New maxims layer defining “maxims propose, evidence disposes” and compiled/uncompiled maxims list.
go-linter-driven-development/examples/switch-to-polymorphism.md	New case law for type-switch → polymorphism with dependency-direction rejection.
go-linter-driven-development/examples/anti-if-dispatch.md	New case law for duplicated discriminator switches → dispatch (plus rejection where switch stays exhaustive).
go-linter-driven-development/commands/go-ldd-status.md	Adds Phase 1.5 PREPARE to status output.
go-linter-driven-development/commands/go-ldd-quickfix.md	Adds cluster routing note to quickfix workflow docs.
go-linter-driven-development/commands/go-ldd-prepare.md	New standalone command for preparatory refactoring.
go-linter-driven-development/commands/go-ldd-autopilot.md	Updates autopilot command docs to include PREPARE step.
go-linter-driven-development/commands/go-ldd-analyze.md	Updates analyze command docs to prefilter R1–R12 and include R11/R12 in Design Debt.
go-linter-driven-development/CHANGELOG.md	Adds entries for 2.2.0–2.6.0 describing R11/R12, PREPARE, maxims, clusters, and links.
go-linter-driven-development/agents/rule-hunter.md	Forbids maxim-based findings (rules-only evidence).
go-linter-driven-development/agents/overabstraction-skeptic.md	Adds named maxim citations as doctrine for skeptic verdicts.
go-linter-driven-development/agents/lint-fixer.md	Routes discriminator-related dupl and exhaustive to R11.
go-linter-driven-development/.claude-plugin/plugin.json	Bumps Go plugin version to 2.6.0 and updates description for 12 rules.
.claude-plugin/marketplace.json	Updates marketplace description to reflect 12-rule Go plugin.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.