Repository navigation
docs: point CLAUDE.md at src/connectors/interface.ts - #447
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The corrected path exists and contains both documented interfaces.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects outdated connector-development documentation to reference the existing interface file.
Changes:
- Updates the
ConnectorandDSNParserinterface path.
| File | Description |
|---|---|
CLAUDE.md |
Points connector guidance to src/connectors/interface.ts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A one-line fix in the "Database Connectors" section of
CLAUDE.md:Why
src/interfaces/connector.tsno longer exists. 1f9c511 ("refactor: move connector interface") renamed it tosrc/connectors/interface.ts, and both interfaces live there at 8c09c86 (DSNParserat line 186,Connectorat line 210). The line was not updated at the time, so anyone (or any coding agent) following the guide to add a connector gets sent to a missing file. This was the only reference to the old path in the repo.Checks
CLAUDE.md.lintlang scan CLAUDE.md(0.8.1) reportsREVIEW(1 medium, H4.5: referenced path does not exist) on the base andPASS(0 findings) on this branch.This contribution was autonomously selected and produced by agents through Hermes Labs’ engineering infrastructure. Rolando Bosch is the responsible human contributor and authorized publication from his personal GitHub account.