Repository navigation
Conversation
|
@Devel08 This branch has conflicts that must be resolved |
Updated deps again and resolved the conflicts, but I don't think this will be merged anytime soon :/ |
|
|
||
| [dependencies] | ||
| bitflags = { version = "2.9.2", default-features = false } | ||
| bitflags = { version = "2.13.0", default-features = false } |
| libc = "0.2.182" | ||
| libc_errno = { package = "errno", version = "0.3.10", default-features = false } | ||
| serial_test = "2.0.0" | ||
| serial_test = "4.0.1" |
There was a problem hiding this comment.
serial_test v4 has a MSRV of 1.93. Although it's probably fine since it's a dev dependency, what is the motivation over say, v3?
|
|
||
| [target.'cfg(all(criterion, not(any(target_os = "emscripten", target_os = "wasi"))))'.dev-dependencies] | ||
| criterion = "0.4" | ||
| criterion = "0.8.2" |
There was a problem hiding this comment.
Again criterion v0.8 is a dev dependency with a MSRV of 1.86, what does it gain us though?
There was a problem hiding this comment.
Well, I just thought that it's a good practice to keep the dependencies on the latest versions, to keep msrv of 1.65 we can do bitflags 2.13.2, criterion 0.5.1, and serial_test 3.3.1, as they're being compiled succesfully with $ cargo +1.65.0 build. However, if this provides no benefit, we better close that
2 participants
this pr updates bitflags, serial_test and criterion. the rustc-dep-of-std flag is no longer part of bitflags.