Repository navigation
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
xtqqczze
force-pushed
the
termios-output-modes
branch
from
October 17, 2026 10:58
5685b6e to
8383862
Compare
Expose additional `termios::OutputModes` flags when supported by `libc`.
xtqqczze
force-pushed
the
termios-output-modes
branch
from
October 17, 2026 11:13
8383862 to
0dcc7a2
Compare
xtqqczze
marked this pull request as ready for review
October 17, 2026 11:28
|
Can we use hand-written const for |
Contributor
Author
This should be easy to address upstream instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose additional
termios::OutputModesflags on Apple targets, as these flags are declared inlibc.Retain the exclusions for
emscripten,fuchsia, andmuslfor now due to a type mismatch inlibc, tracked in rust-lang/libc#5637.Addresses #1706.