Repository navigation
Conversation
Contributor
@jadenfix Could you please review your own contribution carefully before requesting human review? |
Author
|
Thanks for the reminder. I've personally reviewed this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS a newly opened pseudo-terminal can return zero from
tcgetpgrp. The libc backend currently passes that toPid::from_raw_unchecked, which requires a positive value. Apply the existing Linux zero-to-OPNOTSUPPhandling on other libc targets too, and update the public documentation and Apple regression expectation.Fixes #1678.
Validation on macOS:
pgrp_pseudoterminaltest panics on the baseline; it passes after the fix.cargo test --features=all-apis: 215 unit/integration tests and 23 doctests passed, 3 tests intentionally ignored.cargo check --no-default-features --features=pty,termios, andcargo fmt --all -- --checkpassed.OPNOTSUPP),/dev/null(NOTTY), and an actual controlling terminal in a child process (the expected positive process group).RUSTDOCFLAGS="-D warnings"check reports the same 13 existing errors on the clean baseline and candidate. Other operating systems and Rust 1.65 were not run locally.Prepared with Codex assistance and independently reviewed by a separate Codex agent. No human review is claimed.