[Test] Move two false-passing tests to the whitelist - #157
Merged
superajun-wsj merged 1 commit intoJul 31, 2026
Conversation
GitHub Actions’ default CI environment does not allow ptrace, causing the following two tests to skip the code paths they are intended to verify while still reporting success: * gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java * serviceability/sa/jmap-hashcode/Test8028623.java As a result, these tests produce false-positive results in CI. This commit moves both tests to the whitelist to avoid misleading test results. A proper fix will be implemented in a follow-up change.
K0u1e
approved these changes
Jul 31, 2026
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent misleading CI signal by excluding two HotSpot jtreg tests that can “pass” in GitHub Actions’ default environment without exercising the intended code paths due to ptrace restrictions.
Changes:
- Add
gc/metaspace/CompressedClassSpaceSizeInJmapHeap.javato the HotSpot jtreg exclude lists for x64 and aarch64. - Add
serviceability/sa/jmap-hashcode/Test8028623.javato the HotSpot jtreg exclude lists for x64 and aarch64.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cvm/conf/jtreg_hotspot8_excludes_x64.list | Excludes the two identified false-passing HotSpot tests on x64. |
| cvm/conf/jtreg_hotspot8_excludes_aarch64.list | Excludes the two identified false-passing HotSpot tests on aarch64. |
Suppressed comments (2)
cvm/conf/jtreg_hotspot8_excludes_x64.list:103
- Please add a short reason token to this exclude entry (e.g., ptrace is disabled on GitHub Actions so the test skips intended code paths and can false-pass). This makes it easier to revisit/remove the exclusion later.
serviceability/sa/jmap-hashcode/Test8028623.java
cvm/conf/jtreg_hotspot8_excludes_aarch64.list:107
- Please add a short reason token to this exclude entry (e.g., ptrace is disabled on GitHub Actions so the test skips intended code paths and can false-pass). This makes it easier to revisit/remove the exclusion later.
serviceability/sa/jmap-hashcode/Test8028623.java
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gc/g1/TestStringSymbolTableStats.java | ||
| gc/logging/TestGCId.java | ||
| gc/metaspace/TestMetaspaceSizeFlags.java | ||
| gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java |
| gc/g1/TestStringSymbolTableStats.java | ||
| gc/logging/TestGCId.java | ||
| gc/metaspace/TestMetaspaceSizeFlags.java | ||
| gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions’ default CI environment does not allow ptrace, causing the following two tests to skip the code paths they are intended to verify while still reporting success:
As a result, these tests produce false-positive results in CI. This commit moves both tests to the whitelist to avoid misleading test results. A proper fix will be implemented in a follow-up change.