fix(css_composer): drop nested comment opener from Doxygen comment - #313
Merged
Merged
Conversation
The cwist_css_minify() comment added in 3b5c5ed spelled out the preserved license-comment syntax, which put a comment opener inside a comment. GCC's -Wcomment flags it, and CI builds with -Werror, so dev (and every PR built against it) fails at css_composer.o. Describe the syntax in words instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Doxygen comment on
cwist_css_minify()from #312 contains a comment opener (/followed by*) inside a comment. CI builds withWERROR=1, so-Wcommentfails the build atsrc/core/html/css_composer.o. This breaks dev's CI and every PR built against dev (e.g. #310's Address/UB Sanitizer job).The fix describes the syntax in words. It only changes the comment.
Checked: every
.cfile touched by #312 compiles with-Wcomment -Werror=comment, and this was the only hit.