Repository navigation
style(app): group app.c includes, drop duplicates; space out assets.c - #363
Merged
Merged
Conversation
app.c: group the includes by origin with a comment per group, and drop the duplicate <cwist/sys/app/app.h> and <cwist/net/http/https.h>. child_idx moves inside the #ifndef __wasi__ block that sets it. assets.c: blank lines between steps and one condition per line in name_is_valid and cwist_app_asset_add. No behavior change.
Member
Author
|
Deslopifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style only, no behavior change.
app.c: includes grouped by origin with a comment per group; duplicate<cwist/sys/app/app.h>and<cwist/net/http/https.h>removed;child_idxmoved inside the#ifndef __wasi__block that sets it;(d != 0).assets.c: blank lines between steps; one condition per line inname_is_validandcwist_app_asset_add.Checked:
WERROR=1build,test_assets,test_listen_ex,test_html_response,test_static_and_range, Emscriptenmake wasm,wasip2-smoke.