Repository navigation
fix(app): restore the async_debug.h include lost in the #361 merge - #364
Merged
Merged
Conversation
The merge of dev into perf/late-fastpath (c18c6f9) kept #361's reactor_rx.h include in app.c and dropped #360's async_debug.h next to it, so cwist_async_debug_enabled() was implicitly declared and every link of dev failed (undefined symbol; ASan, TSan, WASM, Rust, Zig, benchmarks). Also document CWIST_REACTOR_LATE_US (#361) in docs/runtime-config.md and its Korean mirror, which the env-check gate from #360 requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev is red since #361 merged: the dev→perf/late-fastpath merge (c18c6f9) kept
#include "../io/reactor_rx.h"inapp.cand dropped#include "../io/async_debug.h"from #360 next to it.cwist_async_debug_enabled()(a static inline in that header) became an implicit declaration, so every link failed withundefined symbol: cwist_async_debug_enabled(ASan, TSan, WASM, Rust/Zig bindings, benchmarks, and every PR merged against dev, e.g. #362).CWIST_REACTOR_LATE_USrow (statustuning) todocs/runtime-config.mdanddocs/ko/runtime-config.md; docs(config): document every CWIST_* runtime variable and gate it (#340) #360's env-check gate fails without it.Checked:
WERROR=1build,make env-check,make api-check,scripts/ciunit tests,test_async_defer,test_listen_ex,test_reactor_late,test_reactor_drain_chunk.