chore: recover release v0.0.56 - #88
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical and moderate workflow and release-recovery findings remain.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Recovers npm release 0.0.56 and adds more reliable MCP Registry publication.
Changes:
- Updates package metadata, server metadata, lockfile, and changelog.
- Adds registry publication retries and a manual publishing workflow.
File summaries
| File | Review summary |
|---|---|
server.json |
Updates registry metadata to 0.0.56. |
package.json |
Updates version; moderate findings remain about the missing tag/release and squash-merge release trigger (1 and 2 votes). |
package-lock.json |
Synchronizes lockfile version metadata. |
CHANGELOG.md |
Adds 0.0.56 release notes. |
.github/workflows/release.yml |
Adds retries; a moderate finding remains about failed recovery after npm publication (1 vote). |
.github/workflows/publish-mcp-registry.yml |
Adds manual publishing; a critical finding remains regarding unpinned upstream binaries with OIDC access (1 vote). |
Review details
Suppressed comments (2)
.github/workflows/release.yml:95
- If all six attempts fail, this step exits before the existing commit/tag steps below it. npm has already published the new version, while the
server.jsonsync is only in the failed job's workspace; rerunning the release workflow will try to publish that same npm version again, and the manual workflow checking outmaincannot see the uncommitted metadata needed to publish it. Persist the version/tag before this non-idempotent registry step, or make recovery resume from the already-published version.
if [ "$attempt" -eq 6 ]; then
echo "MCP Registry publish failed after $attempt attempts"
exit 1
fi
package.json:3
- Because the recovery commit is intentionally skipped by the release job, this version bump never reaches the workflow's existing
git tag "v${VERSION}"and GitHub Release steps. The next release will still resolvev0.0.55asPREV_TAG, so the 0.0.56 changes can be attributed again to 0.0.57 and v0.0.56 remains without a release tag. Please create/push thev0.0.56tag (and corresponding GitHub release) as part of this recovery, or add a workflow path that does so.
"version": "0.0.56",
- Files reviewed: 5/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - name: Publish to MCP Registry | ||
| run: | | ||
| curl -sL "https://github.com/modelcontextprotocol/registry/releases/latest/download/mcp-publisher_linux_amd64.tar.gz" | tar xz mcp-publisher |
| { | ||
| "name": "@cablate/mcp-google-map", | ||
| "version": "0.0.55", | ||
| "version": "0.0.56", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
The original release run published npm 0.0.56 successfully, then MCP Registry queried npm before that version became visible. This PR completes that same version and must be merged with a commit message containing chore: release so the normal release workflow does not create 0.0.57.