Skip to content

[REHEARSAL] scaffold: emit a program-id output block per program - #7

Closed
michael-moffett wants to merge 2 commits into
rehearsal-base-339from
p032/scaffold-339-program-id-output
Closed

[REHEARSAL] scaffold: emit a program-id output block per program#7
michael-moffett wants to merge 2 commits into
rehearsal-base-339from
p032/scaffold-339-program-id-output

Conversation

@michael-moffett

Copy link
Copy Markdown
Member

Fork-internal CI rehearsal. Not for merge, not for upstream.

Rehearses p032/scaffold-339-program-id-output (head e0de52b) against .github/workflows/ on real
runner images before the change is offered anywhere else. Base is this fork's main.

Change under test: crates/cli/src/scaffold/mod.rs, +42 / −0, one file.

Base branch note: this fork's main is 4971d40d, exactly one commit behind
solana-foundation/surfpool@de6a055. main was deliberately not fast-forwarded, because
release_crates.yaml and release_cli.yaml fire on push: branches: [main] and firing a publish
workflow to rehearse a test workflow is not a trade worth making. 4971d40d is an ancestor of de6a055,
so refs/pull/N/merge resolves to e0de52b's tree exactly and CI tests the intended bytes.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

The PR extends scaffold generation to emit a program-ID output block for every deployed program.

  • Appends output blocks in both in-memory and on-disk IaC scaffolding paths.
  • Adds a focused unit test covering multiple programs and output-block separation.

Confidence Score: 4/5

The PR should not be merged while the previously reported lost-update race in the airdrop helper remains outstanding.

The airdrop helper still reads a balance in one RPC request and later writes the computed absolute balance in another, so a concurrent balance mutation can be overwritten.

Files Needing Attention: crates/sdk-node/surfpool-sdk/kit/surfpool.ts

Important Files Changed

Filename Overview
crates/cli/src/scaffold/mod.rs Adds a shared program-ID output template, integrates it into both scaffold paths, and tests multi-program rendering.

Reviews (2): Last reviewed commit: "test(scaffold): assert the program-outpu..." | Re-trigger Greptile

Comment thread crates/sdk-node/surfpool-sdk/kit/surfpool.ts
@michael-moffett
michael-moffett changed the base branch from main to rehearsal-base-339 August 22, 2026 13:43
@michael-moffett
michael-moffett force-pushed the p032/scaffold-339-program-id-output branch from e0de52b to 681bd00 Compare August 24, 2026 15:31
@michael-moffett

Copy link
Copy Markdown
Member Author

Superseded: base was rehearsal-base-339, and no workflow in this tree triggers on a PR into a branch by that name (rust.yml is pull_request: branches: ["main"]), so the only check that could ever appear here was the Greptile app. Reopening against main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant