[REHEARSAL] scaffold: emit a program-id output block per program - #7
[REHEARSAL] scaffold: emit a program-id output block per program#7michael-moffett wants to merge 2 commits into
Conversation
Greptile SummaryThe PR extends scaffold generation to emit a program-ID output block for every deployed program.
Confidence Score: 4/5The PR should not be merged while the previously reported lost-update race in the airdrop helper remains outstanding. The airdrop helper still reads a balance in one RPC request and later writes the computed absolute balance in another, so a concurrent balance mutation can be overwritten. Files Needing Attention: crates/sdk-node/surfpool-sdk/kit/surfpool.ts
|
| Filename | Overview |
|---|---|
| crates/cli/src/scaffold/mod.rs | Adds a shared program-ID output template, integrates it into both scaffold paths, and tests multi-program rendering. |
Reviews (2): Last reviewed commit: "test(scaffold): assert the program-outpu..." | Re-trigger Greptile
e0de52b to
681bd00
Compare
|
Superseded: base was |
Fork-internal CI rehearsal. Not for merge, not for upstream.
Rehearses
p032/scaffold-339-program-id-output(heade0de52b) against.github/workflows/on realrunner images before the change is offered anywhere else. Base is this fork's
main.Change under test:
crates/cli/src/scaffold/mod.rs, +42 / −0, one file.Base branch note: this fork's
mainis4971d40d, exactly one commit behindsolana-foundation/surfpool@de6a055.mainwas deliberately not fast-forwarded, becauserelease_crates.yamlandrelease_cli.yamlfire onpush: branches: [main]and firing a publishworkflow to rehearse a test workflow is not a trade worth making.
4971d40dis an ancestor ofde6a055,so
refs/pull/N/mergeresolves toe0de52b's tree exactly and CI tests the intended bytes.