branch_prefix and batch caps become live, configurable settings - #163
Merged
Conversation
write_gate.py's branch-name builders and batches.py's plan_batches now take branch_prefix/batch_byte_cap/batch_file_cap as parameters instead of reading hardcoded module constants, sourced from ctx.obj at the start-branch, propose-pr, and batch-plan CLI call sites.
Contributor
|
Contributor
|
Version hint: patch Comment ID: Display version hint-auto-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_gate.py's branch-name builders (start_wiki_branch,propose_pr) andbatches.py'splan_batchesnow takebranch_prefix/batch_byte_cap/batch_file_capas parameters instead of reading hardcoded module constantsstart-branch,propose-pr, andbatch-planpass these values fromctx.obj(resolved bysettings.build_context)Closes #158
Test plan
uv run pytest— 265 passedbranch_prefixproduces branch names using that prefix (test_write_gate.py); non-defaultbatch_byte_cap/batch_file_capchangeplan_batchesoutput (test_batches.py)WIKI_TOOLKIT_BRANCH_PREFIXandWIKI_TOOLKIT_BATCH_FILE_CAPenv vars changestart-branch/batch-planoutput (test_cli.py)ruff check/ruff formatclean (pre-existing unrelated lint errors unchanged)