Add ADR-0012 for settings-as-a-seam (closes #160) - #165
Merged
Conversation
Records the Context model, build_context() entry point, dedicated .wiki-toolkit.toml precedence tier, and doctor's new settings warnings, superseding ADR-0007's docs_dir-only precedence chain and config show/doctor contracts. toolkit-spec.md's Configuration and Command surface sections were already revised in af869d5; the to_explore/settings-changes.md source doc never existed in this repo. Closes #160
Contributor
|
Contributor
|
Version hint: no-release Comment ID: Display version hint-auto-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/adr/0012-settings-as-a-seam.md, recording theContextmodel,build_context()entry point, dedicated.wiki-toolkit.tomlprecedence tier, anddoctor's new settings warnings, superseding ADR-0007'sdocs_dir-only precedence chain andconfig show/doctorcontracts.toolkit-spec.md's Configuration and Command surface sections were already revised inaf869d5(prior commit), so this PR only adds the ADR.docs/design/to_explore/settings-changes.mdnever existed in this repo (checked history and worktree), so no delete/archive was needed.Test plan
wiki_toolkit/settings.py(Context,build_context, dedicated-file precedence, non-raising resolution) andwiki_toolkit/cli.py/doctor.py(ctx.obj,config show,doctorwarnings)pre-commit(rumdl) passed on the new file/code-review mediumreturned no findings