Delete dead resolve_docs_dir() cluster from settings.py - #170
Merged
Conversation
ADR-0012 superseded this ADR-0007 resolver with build_context() and named it as debt to remove separately. Nothing outside tests called it. Fixes #166
Contributor
|
Contributor
|
Version hint: minor Comment ID: Display version hint-auto-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_docs_dir(),ResolvedConfig,_EnvSettings,_find_pyproject_docs_dirfromwiki_toolkit/settings.py— ADR-0012 superseded this ADR-0007 resolver withbuild_context(), and nothing outside tests called it.tests/test_settings.py, trims the module docstring to describebuild_context()only.Test plan
uv run pytest— 267 passeduv run ruff check/ruff format --check— cleanuv run mypy wiki_toolkit/settings.py— clean/code-review— one finding (stale ADR-0012 note), addressedFixes #166