Move calculate_scan_scope out of cli.py into sources.py - #171
Merged
Conversation
Restores the ADR-0002 thin-CLI seam: the scope/unmatched-id computation is now a plain function next to SourceScanResult, directly unit-tested in test_sources.py instead of only exercised through Click's CliRunner. cli.py keeps only the click.echo loop. Closes #167
Contributor
|
Contributor
|
Version hint: patch Comment ID: Display version hint-auto-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_scan_scope()(pure scope/unmatched-id computation) fromcli.pyintosources.py, next toSourceScanResultcli.py'ssource_scan()keeps only theclick.echoloop over the returned unmatched set, restoring the ADR-0002 thin-CLI seamtest_sources.py(no-filter path and unmatched-id path)Test plan
uv run pytest tests/— 269 passeduv run ruff check/ruff format --checkon touched filesuv run mypyon touched files/code-review— no findingsCloses #167