Collapse ctx.obj/ctx.meta settings split in cli.py - #173
Merged
Conversation
config_show and doctor read the per-field source map via Context.sources now, alongside the rest of the resolved settings on ctx.obj, instead of a second ctx.meta lookup.
Contributor
|
Contributor
|
Version hint: patch Comment ID: Display version hint-auto-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_showanddoctornow read the resolved settings via@click.pass_objalone, dropping thectx.metafallback idiom.Context.sources(a private attr + property, set bybuild_context()), bundling it with the rest of the resolved settings instead of a separate Click channel.Closes #168
Test plan
uv run pytest -q(269 passed)uv run mypy/pyright clean on changed filesuv run ruff checkcleanbuild_context()tuple return,_sourcesset post-construction) — out of scope for this ticket, would require touchingsettings.py's broader public API and its many test callers.