fix(ios): make snapshot presentation construction private - #1937
Merged
Conversation
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed files
|
Member
Author
|
Clean review at d82bd8d. PresentedNode construction is now owned by SnapshotPresentation, while payload encoding and the explicit single-element read paths remain intact. The compiler-boundary proof is non-vacuous, and all required CI plus iOS/macOS/Android/Linux smoke checks are green. Ready for human review. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #1797.
The merged #1930, #1931, and #1933 prerequisites establish backend conformance, effective geometry, and daemon-owned occlusion. This focused slice closes the remaining construction-boundary gap:
This PR does not touch the #1936 scanner or package-boundary files.
The broader #1797 obligations remain intentionally separate: the cumulative-clip choke and named quality downgrade, deterministic differential fixtures and multidimensional ratchets, nightly live differential wiring, cross-runtime golden conformance, and the visible-depth frontier.
Validation