Skip to content

refactor: split debug symbols workflow modules#787

Merged
thymikee merged 4 commits into
mainfrom
codex/debug-symbols-workflow-modules
Jun 12, 2026
Merged

refactor: split debug symbols workflow modules#787
thymikee merged 4 commits into
mainfrom
codex/debug-symbols-workflow-modules

Conversation

@thymikee

@thymikee thymikee commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

Refactors crash symbolication internals into focused modules for artifact parsing/writing, dSYM UUID discovery and matching, symbolication command execution, compact report shaping, and shared workflow types/utilities while preserving the existing debug symbols command surface and output/artifact contract.

Closes #784

Touched files: 7.

Validation

  • pnpm format
  • pnpm exec vitest run src/__tests__/debug-symbols.test.ts src/__tests__/cli-debug-symbols.test.ts (15 tests passed)
  • pnpm check:quick
  • pnpm build
  • Live smoke from an isolated review worktree using an existing real simulator crash artifact and matching dSYM:
    • command: node bin/agent-device.mjs debug symbols --artifact /Users/thymikee/Library/Logs/DiagnosticReports/CrashSymbolProbe-2026-06-11-131543.ips --dsym /private/tmp/agent-device-crash-probe/CrashSymbolProbe.app.dSYM --out /private/tmp/agent-device-pr-787-symbolicated.ips
    • result: compact output, Symbolicated 3 frames, first actionable frame CrashSymbolProbeTrigger (main.m:8), matched UUID 76C74FACC6203472951FEBB0DC7833B5 arm64, full artifact written to /private/tmp/agent-device-pr-787-symbolicated.ips

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.3 MB 1.3 MB +555 B
JS gzip 409.5 kB 409.8 kB +319 B
npm tarball 542.6 kB 543.2 kB +630 B
npm unpacked 1.8 MB 1.8 MB +1.8 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 25.9 ms 26.0 ms +0.1 ms
CLI --help 51.5 ms 52.0 ms +0.5 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/6133.js +134.8 kB +40.3 kB
dist/src/9542.js +46 B +79 B
dist/src/cli.js +56 B +21 B
dist/src/cli-output.js +31 B +19 B
dist/src/android.js 0 B -4 B

@thymikee

Copy link
Copy Markdown
Member Author

I reran the live crash-symbolication smoke from an isolated review worktree because the PR body currently says this was blocked.

Validation passed on the existing real simulator crash artifact and matching dSYM:

  • branch: codex/debug-symbols-workflow-modules at f088b32e7
  • build: pnpm build
  • focused tests: pnpm exec vitest run src/__tests__/debug-symbols.test.ts src/__tests__/cli-debug-symbols.test.ts -> 2 files, 15 tests passed
  • command: node bin/agent-device.mjs debug symbols --artifact /Users/thymikee/Library/Logs/DiagnosticReports/CrashSymbolProbe-2026-06-11-131543.ips --dsym /private/tmp/agent-device-crash-probe/CrashSymbolProbe.app.dSYM --out /private/tmp/agent-device-pr-787-symbolicated.ips
  • result: compact output, Symbolicated 3 frames, first actionable frame CrashSymbolProbeTrigger (main.m:8), matched UUID 76C74FACC6203472951FEBB0DC7833B5 arm64, artifact written to /private/tmp/agent-device-pr-787-symbolicated.ips

Please update the PR body to replace the blocked-live-smoke note with this evidence before merge. I am continuing the code review separately.

@thymikee thymikee force-pushed the codex/debug-symbols-workflow-modules branch from f088b32 to d997d5a Compare June 12, 2026 12:14
@thymikee thymikee merged commit 1da6fd5 into main Jun 12, 2026
19 checks passed
@thymikee thymikee deleted the codex/debug-symbols-workflow-modules branch June 12, 2026 12:44
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-12 12:45 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(debug): split crash symbolication workflow into focused modules

1 participant