Skip to content

fix: tighten iOS runner crash classification#797

Open
thymikee wants to merge 1 commit into
mainfrom
codex/tighten-ios-runner-crash-classification
Open

fix: tighten iOS runner crash classification#797
thymikee wants to merge 1 commit into
mainfrom
codex/tighten-ios-runner-crash-classification

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Tightens the generic iOS target-app crash heuristic added by #793 so incidental XCTest logs containing the word crashed do not reclassify ordinary COMMAND_FAILED runner errors.

Adds boundary coverage for explicit target-app crashes and a benign XCTest near-miss that should remain retryable.

Validation

pnpm exec vitest run src/platforms/ios/tests/runner-client.test.ts

pnpm check:fallow --base origin/main

pnpm check:quick

pnpm format

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.3 MB 1.3 MB -45 B
JS gzip 411.6 kB 411.6 kB -7 B
npm tarball 544.6 kB 544.6 kB -1 B
npm unpacked 1.8 MB 1.8 MB -45 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.2 ms 25.8 ms -0.4 ms
CLI --help 51.2 ms 50.9 ms -0.2 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/2415.js -45 B -7 B

@thymikee

Copy link
Copy Markdown
Member Author

Android smoke failure appears to be CI/emulator cleanup rather than the smoke command itself. The log shows 01-settings.ad passed, android-snapshot-helper-release-smoke.sh installed/opened the smoke app, then adb emu kill returned OK at 18:59:59. The job later sat until the workflow canceled it at 20:16:53 and cleaned orphan qemu/adb/node processes.

Suggested next step: rerun only the Android smoke job before treating this as a product failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant