fix: tighten iOS runner crash classification#797
Open
thymikee wants to merge 1 commit into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Android smoke failure appears to be CI/emulator cleanup rather than the smoke command itself. The log shows Suggested next step: rerun only the Android smoke job before treating this as a product failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the generic iOS target-app crash heuristic added by #793 so incidental
XCTestlogs containing the wordcrasheddo not reclassify ordinaryCOMMAND_FAILEDrunner errors.Adds boundary coverage for explicit target-app crashes and a benign
XCTestnear-miss that should remain retryable.Validation
pnpm exec vitest run src/platforms/ios/tests/runner-client.test.ts
pnpm check:fallow --base origin/main
pnpm check:quick
pnpm format