perf: improve Android Maestro snapshot helper performance#799
Open
thymikee wants to merge 3 commits into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve Android Maestro replay performance by letting persistent snapshot-helper requests use the helper command budget instead of timing out early, and by disabling the helper idle wait by default because daemon-side post-gesture stabilization already handles settling. This avoids repeated timeout-plus-fallback behavior on busy React Navigation drawer screens.
Touched-file count: 3. Scope is Android snapshot helper runtime/tests only.
Validation
Focused unit coverage passed:
pnpm exec vitest run src/platforms/android/__tests__/snapshot.test.ts src/platforms/android/__tests__/snapshot-helper-session.test.ts(46/46).Static checks passed via direct underlying gates because this worktree's aggregate
pnpm check:quickhit a pnpm version guard before running checks:npm_config_pm_on_fail=ignore pnpm lint(0 warnings/errors) andnpm_config_pm_on_fail=ignore pnpm typecheck.Live Android validation on
emulator-5554, apporg.reactnavigation.playground, React Navigation 10-file Maestro subset: missing local helper artifacts failed/slow at 8/10 in 350.9s; packaged helpers on PR #795 passed 10/10 in 183.7s; this branch passed 10/10 in 155.2s. Focuseddrawer-master-detail.ymlimproved from 84.2s on PR #795 helper path to 66.2s with the session timeout change and 55.1s with the idle-wait change.