Skip to content

fix(babel): emit forward slashes in generated import paths on Windows #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KallinikosMil wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

fix(babel): emit forward slashes in generated import paths on Windows #5054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions scripts/generate-mappings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ import { parse } from '@babel/parser';
import * as types from '@babel/types';
import type { Identifier, StringLiteral } from '@babel/types';
import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
import { dirname, join, relative as relativePath, resolve } from 'node:path';
import {
dirname,
join,
relative as relativePath,
resolve,
sep,
} from 'node:path';
import { fileURLToPath } from 'node:url';

type PackageJson = {
Expand Down Expand Up @@ -49,8 +55,12 @@ const ast = parse(source, {
});

const index = packageJson.main;
// The result ends up in an import specifier, which always uses forward slashes,
// so normalise the platform separator that `relative` returns on Windows.
const relative = (value: string) =>
relativePath(root, resolve(root, dirname(index), value));
relativePath(root, resolve(root, dirname(index), value))
.split(sep)
.join('/');

const mappings = ast.program.body.reduce<{ [key: string]: Mapping }>(
(acc, declaration, _index, self) => {
Expand Down