Repository navigation
fix(jpeg): android jpeg drawable resources - #1480
Merged
dannyhw merged 1 commit intoOct 9, 2026
Merged
Conversation
|
@CristiCeban is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 81b4e8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CristiCeban
force-pushed
the
fix/android-jpeg-drawable-resources
branch
from
October 9, 2026 08:47
6cbb2eb to
6fd2fed
Compare
CristiCeban
force-pushed
the
fix/android-jpeg-drawable-resources
branch
from
October 9, 2026 08:50
6fd2fed to
81b4e8f
Compare
dannyhw
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1479. In Android release builds,
.jpegimages don't show:<Image source={require('./photo.jpeg')} />renders empty, while the same file renamed to.jpgworks.Re.Pack's assets loader only sends
png|jpg|gif|webptodrawable-*, so.jpegends up inraw. React Native looks upjpegas a drawable (drawableFileTypesin@react-native/asset-utils), so it can't find the image.This PR makes the loader's image list match React Native's
drawableFileTypes(gif|heic|heif|jpeg|jpg|ktx|png|webp;xmlis still handled separately). It also updates the Android resource directories table in the Assets loader docs.Test plan
png,jpg,jpeg,gif,webp→drawable-mdpi;bmp,svg→raw. Before the fix, onlyjpegfailed (rspack and webpack).tests/integration(140) andpackages/repackunit tests (347) pass;pnpm lint:ciis clean.minifyEnabled+shrinkResources) on an emulator:.jpegwas packaged underraw/and the<Image>rendered empty.drawable/and renders next to.jpgand.png..jpegpackaged underraw/,<Image>renders empty.jpegpackaged underdrawable/, renders like.jpgand.png