Skip to content

fix(daemon): a stop waits for health ticks and recoveries in flight - #1004

Merged
V3RON merged 3 commits into
mainfrom
bug/1000
Oct 25, 2026
Merged

V3RON merged 3 commits into
mainfrom
bug/1000

Conversation

@V3RON

@V3RON V3RON commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1000

Status

Implement: done (audit 2 fixes) Review: round 1 passed, 0 findings Hardware: n/a Gate: running
Next: gate

Done when

  • A graceful stop waits for a health tick or recovery reboot already running, including one that starts during the stop, before the drivers and state.db are closed. — the #1000 test in src/daemon/main.test.ts (both cases) and the settle() test in src/leasing/lease-health-monitor.test.ts; review round 1 mutation probes made each fail

Assumptions

none

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 1 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 2.6M.
Runs: 6. Cost USD: 1.4054. Agent seconds: 737.

Assessment: complete

Written by an agent.

@V3RON

V3RON commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: e6f886f

Runs: 6. Cost USD: 1.4054. Agent seconds: 737.
Tokens input 148, output 32418, cache read 2379083, cache write 222875.
- build implementer: claude-sonnet-5-5 161 s $0.1937
- audit implementer: claude-sonnet-5-5 155 s $0.2415
- review 1 reviewer: claude-sonnet-5-5 230 s $0.2092
- review 1 spec-reviewer spec: claude-sonnet-5-5 23 s $0.1014
- review 1 code-reviewer both: claude-opus-5-5 148 s $0.5715
- review 1 claims-reviewer claims: claude-sonnet-5-5 20 s $0.0881
Finding outcomes: {}. Classes: {}.
{"findings":[]}

Written by an agent.

@V3RON

V3RON commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • code: src/leasing/lease-health-monitor.ts:316 a recovery past its first attempt still reboots after dispose (matches the triage, which rejected aborting a reboot); a backoff that dispose ends early returns before rebooting

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 25, 2026 12:40
@V3RON
V3RON merged commit 2522402 into main Oct 25, 2026
78 checks passed
@V3RON
V3RON deleted the bug/1000 branch October 25, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A health recovery that starts while the daemon stop waits for cleanup is not waited for

1 participant